Remove @storybook/addon-storyshots types

[gaetanmaisse]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.

Select one of these and delete the others:

If removing a declaration:

• Delete the package's directory.
• Add it to notNeededPackages.json.

--

@storybook/addon-storyshots and @storybook/addon-storyshots-puppeteer were migrated to TS in this PR storybookjs/storybook#4758 and publically available with Storybook 5.3.0 release.

[typescript-bot]

@gaetanmaisse Thank you for submitting this PR!

🔔 @bradleyayers @Yama-Tomo - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[Yama-Tomo]

LGTM 👍

[SimenB]

we get this now - is it caused by the change in this pr?

error Couldn't find package "storybook__addon-storyshots@*" required by "@types/storybook__addon-storyshots@^5.0.0" on the "npm" registry.

[gaetanmaisse]

@SimenB it is surely related. As @storybook/addon-storyshots now exports its own types I removed the old and not up to date ones from DefinitelyTyped. You can either use the last version available on DefinitelyTyped i.e. @types/storybook__addon-storyshots@5.1.2 or remove it completely and use types provided by the package itself.
Didn't expect to throw an error like this and not fall back to the latest available types 😞

[SimenB]

Installing it shouldn't error though, that's a bug

[gaetanmaisse]

Great, I'm not crazy, that's not the correct behavior.
Not great, it looks like there is something broken for all scoped packages.

[SimenB]

@sandersn seems to be a bug in the publisher?

[sandersn]

Yep, looks like the publisher forgets to unmangle the name before adding the dependency.

The dependency is kind of bogus anyway -- it's a deprecated package!

[sandersn]

It should now be fixed for future deprecations; I didn't fix the 38 existing packages that the buggy code generated because (1) it's a royal pain (2) the workaround -- deleting the @types/storybook__addon-storyshots dependency -- seems easy. I'm happy to discuss whether I'm wrong about that.

[sandersn]

Never mind, I decided to fix them. The fixup script wasn't that hard to write...