Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@pollyjs/core] Update types for v4.0.0 #41769

Merged
merged 1 commit into from Jan 25, 2020
Merged

[@pollyjs/core] Update types for v4.0.0 #41769

merged 1 commit into from Jan 25, 2020

Conversation

offirgolan
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Netflix/pollyjs/blob/master/CHANGELOG.md#400-2020-01-13
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to pollyjs__core with its source on master.

Comparison details 📊
Batch compilation
Type count 2551
Assignability cache size 230
Language service measurements
Samples taken 297
Identifiers in tests 297
getCompletionsAtPosition
    Mean duration (ms) 76.0
    Mean CV 15.6%
    Worst duration (ms) 103.8
    Worst identifier setupMocha
getQuickInfoAtPosition
    Mean duration (ms) 77.7
    Mean CV 15.2%
    Worst duration (ms) 107.3
    Worst identifier record
System information
Node version v12.14.0
CPU count 2
CPU speed 2.394 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1064-azure

@typescript-bot typescript-bot added this to Needs Author Attention in Pull Request Status Board Jan 21, 2020
@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. The Travis CI build failed labels Jan 21, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 21, 2020

@offirgolan Thank you for submitting this PR!

🔔 @feinoujc @BoruiGu - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 21, 2020

@offirgolan The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

package.json Outdated Show resolved Hide resolved
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 24, 2020

@offirgolan The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 608cbe0.

pollyjs__core/v4

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to pollyjs__core with its source on master.

Comparison details for pollyjs__core/v4 📊
Batch compilation
Type count 2553
Assignability cache size 230
Language service measurements
Samples taken 301
Identifiers in tests 301
getCompletionsAtPosition
    Mean duration (ms) 87.5
    Mean CV 15.0%
    Worst duration (ms) 122.2
    Worst identifier port
getQuickInfoAtPosition
    Mean duration (ms) 90.1
    Mean CV 14.9%
    Worst duration (ms) 122.0
    Worst identifier bar
System information
Node version v12.14.1
CPU count 2
CPU speed 2.397 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1066-azure

setup-polly-jest/v*

Comparison details for setup-polly-jest/v* 📊
master #41769 diff
Batch compilation
Memory usage (MiB) 34.2 34.2 0.0%
Type count 2325 2327 0%
Assignability cache size 116 116 0%
Language service
Samples taken 23 23 0%
Identifiers in tests 23 23 0%
getCompletionsAtPosition
    Mean duration (ms) 88.7 87.5 -1.4%
    Mean CV 21.2% 22.6%
    Worst duration (ms) 114.0 103.5 -9.2%
    Worst identifier record context
getQuickInfoAtPosition
    Mean duration (ms) 83.0 85.2 +2.6%
    Mean CV 13.3% 16.4% +23.5%
    Worst duration (ms) 99.5 103.8 +4.3%
    Worst identifier setupPolly record

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jan 24, 2020
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Jan 24, 2020
@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@uniqueiniquity uniqueiniquity merged commit 60c8a72 into DefinitelyTyped:master Jan 25, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Jan 25, 2020
@typescript-bot
Copy link
Contributor

I just published @types/pollyjs__core@4.0.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants