Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/passport-auth0: Add default export to type definition #42315

Merged
merged 21 commits into from
Feb 18, 2020
Merged

@types/passport-auth0: Add default export to type definition #42315

merged 21 commits into from
Feb 18, 2020

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Feb 12, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/auth0/passport-auth0/blob/09f18140de08ca9f7dc1549a881e8bd5eee9ffd4/lib/index.js#L187-L190
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #42315 diff
Batch compilation
Memory usage (MiB) 62.9 64.3 +2.2%
Type count 10675 10669 0%
Assignability cache size 3420 3413 0%
Language service
Samples taken 135 134 -1%
Identifiers in tests 135 134 -1%
getCompletionsAtPosition
    Mean duration (ms) 304.2 307.8 +1.2%
    Mean CV 10.3% 11.6%
    Worst duration (ms) 378.8 370.8 -2.1%
    Worst identifier Profile auth0
getQuickInfoAtPosition
    Mean duration (ms) 304.2 304.1 0.0%
    Mean CV 11.8% 11.4% -3.2%
    Worst duration (ms) 371.5 382.6 +3.0%
    Worst identifier done env

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 12, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 12, 2020

@karlhorky Thank you for submitting this PR!

🔔 @johnbendi @iamvishnusankar @duncanhall - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

@karlhorky The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 12, 2020

@karlhorky The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Cannot test for a default import

Ref: #41948 (comment)
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 12, 2020

@karlhorky The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot
Copy link
Contributor

@karlhorky The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot moved this from Needs Author Attention to Waiting for Reviewers in Pull Request Status Board Feb 13, 2020
@karlhorky
Copy link
Contributor Author

karlhorky commented Feb 14, 2020

cc @iamvishnusankar or @johnbendi or @duncanhall, could one of you review this?

Short version: this enables importing the default export as well as the named export.

Long version: microsoft/TypeScript#36774

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Feb 18, 2020
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Feb 18, 2020
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@karlhorky
Copy link
Contributor Author

Or @sandersn, maybe you can review since you've already reviewed this code?

Copy link
Contributor

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the merge conflicts are fixed.

(Was that another one of your PRs or is passport-auth0 just super popular all of a sudden?)

@typescript-bot typescript-bot moved this from Review to Needs Author Attention in Pull Request Status Board Feb 18, 2020
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Unmerged The author did not merge the PR when it was ready. labels Feb 18, 2020
@typescript-bot
Copy link
Contributor

@karlhorky Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@karlhorky
Copy link
Contributor Author

Great thanks!

Looks like it's another PR that caused the conflict:

758c013

@sandersn sandersn merged commit e73517f into DefinitelyTyped:master Feb 18, 2020
Pull Request Status Board automation moved this from Needs Author Attention to Done Feb 18, 2020
@karlhorky
Copy link
Contributor Author

Thanks @sandersn!

@karlhorky karlhorky deleted the patch-1 branch February 19, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Other Approved This PR was reviewed and signed-off by a community member. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants