Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @theme-ui/color #42358

Merged
merged 2 commits into from Feb 14, 2020
Merged

Conversation

allanpope
Copy link
Contributor

@allanpope allanpope commented Feb 13, 2020

Note: Build failing due to Polished not being on whitelist. Have created a pull request here.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.

@typescript-bot typescript-bot added this to Needs Author Attention in Pull Request Status Board Feb 13, 2020
@typescript-bot typescript-bot added New Definition This PR creates a new definition package. The Travis CI build failed labels Feb 13, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 13, 2020

@allanpope Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 13, 2020

@allanpope The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@allanpope allanpope closed this Feb 13, 2020
Pull Request Status Board automation moved this from Needs Author Attention to Done Feb 13, 2020
@allanpope allanpope reopened this Feb 13, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to theme-ui__color with its source on master.

Comparison details 📊
Batch compilation
Type count 2430
Assignability cache size 128
Language service measurements
Samples taken 33
Identifiers in tests 33
getCompletionsAtPosition
    Mean duration (ms) 79.8
    Mean CV 28.5%
    Worst duration (ms) 104.5
    Worst identifier desaturate
getQuickInfoAtPosition
    Mean duration (ms) 76.4
    Mean CV 27.7%
    Worst duration (ms) 99.3
    Worst identifier grayscale
System information
Node version v12.14.1
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1066-azure

@typescript-bot typescript-bot moved this from Done to Review in Pull Request Status Board Feb 13, 2020
@sandersn sandersn merged commit 35f0b3b into DefinitelyTyped:master Feb 14, 2020
Pull Request Status Board automation moved this from Review to Done Feb 14, 2020
@hasparus
Copy link
Contributor

Hey @allanpope 👋 The order of parameters is reversed.

From theme-ui/color source.

export const transparentize = (c, n) => t => P.transparentize(n, g(t, c))

@allanpope allanpope mentioned this pull request Feb 17, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants