Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jest pinned dependencies #43613

Merged
merged 4 commits into from Apr 3, 2020

Conversation

berickson1
Copy link
Contributor

@berickson1 berickson1 commented Apr 3, 2020

jest-diff and pretty-format were previously pinned in #43531 to work around backwards compatibility issues with the typescript definitions. Facebook added tooling to allow down-leveling their type definition in jestjs/jest@d4057ce, which landed in 25.2.1, so bump the semver dependency to this.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • [] Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: N/A
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

`jest-diff` and `pretty-format` were previously pinned in DefinitelyTyped#43531 to work around backwards compatibility issues with the typescript definitions. Facebook added tooling to allow down-leveling their type definition in jestjs/jest@d4057ce, which landed in 25.2.7, so bump the semver dependency to this.
@berickson1
Copy link
Contributor Author

More discussion about this in comments of #43531

@typescript-bot typescript-bot added this to Needs Author Attention in Pull Request Status Board Apr 3, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Apr 3, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 3, 2020

@berickson1 Thank you for submitting this PR!

🔔 @JoshuaKGoldberg @tkrotoff @jfm710 @cwoodland @johnny4753 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @favna @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @erbridge @dawnmist @geovanisouza92 @deadNightTiger @lvl99 @joemitchard @jonasheinrich @aldentaylor @immanuel192 @sehsyha @gnapse @jgoz @smacpherson64 @mistic100 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 3, 2020

@berickson1 The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Copy link
Contributor

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line of types/jest/index.d.ts please change it to

- // Type definitions for Jest 25.1
+ // Type definitions for Jest 25.2

Also please fill out the pull request template properly. As it says

Select one of these and delete the others:

So remove "If adding a new definition:" and "If removing a declaration:" and properly fill in "If changing an existing definition:"

Also address the failing Travis build. You're going to have to bump the minimum TS version on other packages as well.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Apr 3, 2020
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Apr 3, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed The Travis CI build failed labels Apr 3, 2020
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@uniqueiniquity uniqueiniquity merged commit 8125c0c into DefinitelyTyped:master Apr 3, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Apr 3, 2020
@typescript-bot
Copy link
Contributor

I just published @types/expect-puppeteer@4.4.1 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/frisby@2.0.7 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-axe@3.2.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-image-snapshot@2.11.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-in-case@1.0.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-json-schema@2.1.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-matcher-one-of@1.0.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-plugin-context@2.9.3 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/jest-when@2.7.1 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants