New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated jest pinned dependencies #43613
Conversation
`jest-diff` and `pretty-format` were previously pinned in DefinitelyTyped#43531 to work around backwards compatibility issues with the typescript definitions. Facebook added tooling to allow down-leveling their type definition in jestjs/jest@d4057ce, which landed in 25.2.7, so bump the semver dependency to this.
More discussion about this in comments of #43531 |
@berickson1 Thank you for submitting this PR! 🔔 @JoshuaKGoldberg @tkrotoff @jfm710 @cwoodland @johnny4753 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @ahnpnl @JoshuaKGoldberg @UselessPickles @r3nya @Hotell @sebald @andys8 @antoinebrault @favna @gstamac @ExE-Boss @quassnoi @Belco90 @tonyhallett @ycmjason @devanshj @pawfa @regevbr @erbridge @dawnmist @geovanisouza92 @deadNightTiger @lvl99 @joemitchard @jonasheinrich @aldentaylor @immanuel192 @sehsyha @gnapse @jgoz @smacpherson64 @mistic100 - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
@berickson1 The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First line of types/jest/index.d.ts
please change it to
- // Type definitions for Jest 25.1
+ // Type definitions for Jest 25.2
Also please fill out the pull request template properly. As it says
Select one of these and delete the others:
So remove "If adding a new definition:" and "If removing a declaration:" and properly fill in "If changing an existing definition:"
Also address the failing Travis build. You're going to have to bump the minimum TS version on other packages as well.
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
I just published |
I just published |
I just published |
I just published |
I just published |
I just published |
I just published |
I just published |
I just published |
jest-diff
andpretty-format
were previously pinned in #43531 to work around backwards compatibility issues with the typescript definitions. Facebook added tooling to allow down-leveling their type definition in jestjs/jest@d4057ce, which landed in 25.2.1, so bump the semver dependency to this.Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.