[d3-scale-chromatic] Upgrade to v1.5.0 #43917
Conversation
| @@ -12,7 +12,7 @@ import * as d3ScaleChromatic from 'd3-scale-chromatic'; | |||
| // Preparatory Steps | |||
| // ----------------------------------------------------------------------- | |||
|
|
|||
| let colorInterpolator: ((t: number) => string); | |||
| let colorInterpolator: (t: number) => string; | |||
There was a problem hiding this comment.
This is from running Prettier.
| const Warm: string = d3ScaleChromatic.interpolateWarm(0.7); | ||
| const Cool: string = d3ScaleChromatic.interpolateCool(0.7); | ||
| const Rainbow: string = d3ScaleChromatic.interpolateRainbow(0.7); | ||
| const Sinebow: string = d3ScaleChromatic.interpolateSinebow(0.7); | ||
| const CubehelixDefault: string = d3ScaleChromatic.interpolateCubehelixDefault(0.7); |
There was a problem hiding this comment.
I've re-ordered the interpolators in this section to match the type definitions and the library's README.
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
typescript-bot
added
the
Perf: Same
typescript-bot
added
Popular package
|
@axelboc Thank you for submitting this PR! 🔔 @Ledragon @gustavderdrache @borisyankov @henriquefm - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
typescript-bot
moved this from Waiting for Reviewers
to Check and Merge
in Pull Request Status Board
typescript-bot
added
Owner Approved
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
I just published |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
If you are making substantial changes, consider adding atslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.