-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Vimeo request() generic to optionally type results #44316
Conversation
@mattleff Thank you for submitting this PR! Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44316,
"author": "mattleff",
"owners": [
"mattleff"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "8e49bd4",
"headCommitOid": "8e49bd4f15ff7e2f31677a019a208b951a0ccc93",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-04T16:30:10.000Z",
"lastAuthorCommentDate": "2020-05-04T18:06:48.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44316/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"vimeo"
],
"files": [
{
"filePath": "types/vimeo/index.d.ts",
"kind": "definition",
"package": "vimeo"
},
{
"filePath": "types/vimeo/tsconfig.json",
"kind": "package-meta",
"package": "vimeo"
},
{
"filePath": "types/vimeo/vimeo-tests.ts",
"kind": "test",
"package": "vimeo"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-04T18:05:03.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 4,
"isChangesRequested": false
} |
@mattleff The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
ping @typescript-bot, what’s with the labels |
@mattleff The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
🔔 @mattleff - please review this PR in the next few days. Be sure to explicitly select |
@andrewbranch Thanks for fixing the dt-mergebot issues. Is this PR good to go now? |
@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mattleff Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
…onally type results by @mattleff * Make Vimeo request() generic to optionally type results * Add tests for vimeo types * Don't type request() method
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.