Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XUMM-API: Add new TX type & API payload meta options #44542

Merged
merged 2 commits into from May 10, 2020
Merged

XUMM-API: Add new TX type & API payload meta options #44542

merged 2 commits into from May 10, 2020

Conversation

WietseWind
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@typescript-bot typescript-bot added Where is Travis? Author is Owner The author of this PR is a listed owner of the package. labels May 7, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented May 7, 2020

@WietseWind Thank you for submitting this PR!

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44542,
  "author": "WietseWind",
  "owners": [
    "WietseWind"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "90612fb",
  "headCommitOid": "90612fb89f3d447c47ef919a9999c2c06feca65d",
  "mergeIsRequested": true,
  "stalenessInDays": 3,
  "lastCommitDate": "2020-05-07T10:05:14.000Z",
  "lastCommentDate": "2020-05-10T18:18:15.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44542/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "xumm-api"
  ],
  "files": [
    {
      "filePath": "types/xumm-api/index.d.ts",
      "kind": "definition",
      "package": "xumm-api"
    },
    {
      "filePath": "types/xumm-api/xumm-api-tests.ts",
      "kind": "test",
      "package": "xumm-api"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "lastReviewDate": "2020-05-10T09:26:45.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 1,
  "isChangesRequested": false
}

@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board May 7, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44542 diff
Batch compilation
Memory usage (MiB) 34.0 34.0 0.0%
Type count 2393 2405 +1%
Assignability cache size 157 157 0%
Language service
Samples taken 209 216 +3%
Identifiers in tests 209 216 +3%
getCompletionsAtPosition
    Mean duration (ms) 61.4 60.2 -1.9%
    Mean CV 19.1% 17.3%
    Worst duration (ms) 87.2 89.1 +2.1%
    Worst identifier XummWebhookBody code
getQuickInfoAtPosition
    Mean duration (ms) 60.8 59.9 -1.5%
    Mean CV 18.0% 16.3% -9.3%
    Worst duration (ms) 86.3 83.1 -3.7%
    Worst identifier blob error

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label May 7, 2020
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 10, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 10, 2020
@typescript-bot
Copy link
Contributor

@WietseWind Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@WietseWind
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 10, 2020
@typescript-bot typescript-bot merged commit 4ba5d8d into DefinitelyTyped:master May 10, 2020
andreialecu pushed a commit to andreialecu/DefinitelyTyped that referenced this pull request May 12, 2020
…oad meta options by @WietseWind

* XUMM: Add new TX type & future meta options

* Update tests
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
…oad meta options by @WietseWind

* XUMM: Add new TX type & future meta options

* Update tests
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Other Approved This PR was reviewed and signed-off by a community member. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants