Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flatMap types for Kefir #44634

Merged
merged 1 commit into from May 15, 2020

Conversation

mAAdhaTTah
Copy link
Contributor

The error type should get combined into the resulting Observable,
rather than being replaced as it is now. merge & concat do
this correctly already.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/kefirjs/kefir/blob/master/kefir.js.flow#L129-L134
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 11, 2020

@mAAdhaTTah Thank you for submitting this PR!

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44634,
  "author": "mAAdhaTTah",
  "owners": [
    "AyaMorisawa",
    "HitoriSensei"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "5ee41e2",
  "headCommitOid": "5ee41e2f950440939ef77c499555ff018dbbe9cf",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-05-15T21:31:33.000Z",
  "lastCommentDate": "2020-05-15T21:34:38.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44634/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "kefir"
  ],
  "files": [
    {
      "filePath": "types/kefir/index.d.ts",
      "kind": "definition",
      "package": "kefir"
    },
    {
      "filePath": "types/kefir/kefir-tests.ts",
      "kind": "test",
      "package": "kefir"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [
    {
      "reviewedAbbrOid": "fe224fc",
      "reviewer": "sandersn",
      "date": "2020-05-15T15:46:51Z"
    }
  ],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @AyaMorisawa @HitoriSensei - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board May 11, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44634 diff
Batch compilation
Memory usage (MiB) 116.9 127.5 +9.1%
Type count 28019 29933 +7%
Assignability cache size 40630 40758 0%
Language service
Samples taken 764 786 +3%
Identifiers in tests 764 786 +3%
getCompletionsAtPosition
    Mean duration (ms) 593.3 598.2 +0.8%
    Mean CV 8.4% 9.1%
    Worst duration (ms) 937.0 922.4 -1.6%
    Worst identifier x x
getQuickInfoAtPosition
    Mean duration (ms) 592.6 599.2 +1.1%
    Mean CV 8.4% 9.1% +9.2%
    Worst duration (ms) 858.0 919.7 +7.2%
    Worst identifier prev constant

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label May 11, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 15, 2020
@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Maintainer Approved labels May 15, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board May 15, 2020
@typescript-bot
Copy link
Contributor

@mAAdhaTTah Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

The error type should get combined into the resulting Observable,
rather than being replaced as it is now. `merge` & `concat` do
this correctly already.
@danger-public
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

kefir (unpkg)

was missing the following properties:

  1. dissableDeprecationWarnings
  2. Kefir

Generated by 🚫 dangerJS against 5ee41e2

@typescript-bot typescript-bot removed Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Maintainer Approved labels May 15, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 15, 2020
@typescript-bot
Copy link
Contributor

@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@sandersn sandersn merged commit 84a9b63 into DefinitelyTyped:master May 15, 2020
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board May 15, 2020
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
The error type should get combined into the resulting Observable,
rather than being replaced as it is now. `merge` & `concat` do
this correctly already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants