New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flatMap types for Kefir #44634
Fix flatMap types for Kefir #44634
Conversation
@mAAdhaTTah Thank you for submitting this PR! Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44634,
"author": "mAAdhaTTah",
"owners": [
"AyaMorisawa",
"HitoriSensei"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "5ee41e2",
"headCommitOid": "5ee41e2f950440939ef77c499555ff018dbbe9cf",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-15T21:31:33.000Z",
"lastCommentDate": "2020-05-15T21:34:38.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44634/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"kefir"
],
"files": [
{
"filePath": "types/kefir/index.d.ts",
"kind": "definition",
"package": "kefir"
},
{
"filePath": "types/kefir/kefir-tests.ts",
"kind": "test",
"package": "kefir"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"reviewersWithStaleReviews": [
{
"reviewedAbbrOid": "fe224fc",
"reviewer": "sandersn",
"date": "2020-05-15T15:46:51Z"
}
],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @AyaMorisawa @HitoriSensei - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@mAAdhaTTah Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
The error type should get combined into the resulting Observable, rather than being replaced as it is now. `merge` & `concat` do this correctly already.
fe224fc
to
5ee41e2
Compare
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. kefir (unpkg)was missing the following properties:
|
@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
The error type should get combined into the resulting Observable, rather than being replaced as it is now. `merge` & `concat` do this correctly already.
The error type should get combined into the resulting Observable,
rather than being replaced as it is now.
merge
&concat
dothis correctly already.
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.