Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt scrollmagic from npm-naming #44853

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

sandersn
Copy link
Contributor

I can't tell from the source whether scrollmagic exports a callable object because all the documentation is for the global usage. However, the global usage is a namespace, not a function, so I suspect the module is the same.

I can't tell from the source whether scrollmagic exports a callable
object because all the documentation is for the global usage. However,
the global usage is a namespace, not a function, so I suspect the module
is the same.
@typescript-bot
Copy link
Contributor

typescript-bot commented May 18, 2020

@sandersn Thank you for submitting this PR!

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ A DT maintainer needs to merge changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44853,
  "author": "sandersn",
  "owners": [
    "switchnollie"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "5364eeb",
  "headCommitOid": "5364eeb7827a07a72a09fae6e09f7f1927edfb88",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-05-18T18:55:46.000Z",
  "lastCommentDate": "2020-05-18T18:58:30.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44853/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "scrollmagic"
  ],
  "files": [
    {
      "filePath": "types/scrollmagic/tslint.json",
      "kind": "package-meta",
      "package": "scrollmagic"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "lastReviewDate": "2020-05-18T19:03:08.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @switchnollie - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 18, 2020
@danger-public
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

scrollmagic (unpkg)

was missing the following properties:

  1. The declaration doesn't match the JavaScript module 'scrollmagic'. Reason:
    The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

  1. Event

Generated by 🚫 dangerJS against 5364eeb

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44853 diff
Batch compilation
Memory usage (MiB) 72.1 81.9 +13.6%
Type count 10325 10325 0%
Assignability cache size 34524 34524 0%
Language service
Samples taken 38 38 0%
Identifiers in tests 38 38 0%
getCompletionsAtPosition
    Mean duration (ms) 355.5 358.4 +0.8%
    Mean CV 16.0% 15.0%
    Worst duration (ms) 403.1 412.0 +2.2%
    Worst identifier ScrollMagic e
getQuickInfoAtPosition
    Mean duration (ms) 336.8 350.4 +4.0%
    Mean CV 12.9% 14.1% +9.0%
    Worst duration (ms) 386.7 420.8 +8.8%
    Worst identifier version log

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label May 18, 2020
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 18, 2020
@sandersn sandersn merged commit 4904929 into master May 18, 2020
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board May 18, 2020
@sandersn sandersn deleted the exempt-scrollmagic-from-npm-naming branch May 18, 2020 19:04
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
I can't tell from the source whether scrollmagic exports a callable
object because all the documentation is for the global usage. However,
the global usage is a namespace, not a function, so I suspect the module
is the same.
ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
I can't tell from the source whether scrollmagic exports a callable
object because all the documentation is for the global usage. However,
the global usage is a namespace, not a function, so I suspect the module
is the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants