-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exempt scrollmagic from npm-naming #44853
Conversation
I can't tell from the source whether scrollmagic exports a callable object because all the documentation is for the global usage. However, the global usage is a namespace, not a function, so I suspect the module is the same.
@sandersn Thank you for submitting this PR! Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44853,
"author": "sandersn",
"owners": [
"switchnollie"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "5364eeb",
"headCommitOid": "5364eeb7827a07a72a09fae6e09f7f1927edfb88",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-18T18:55:46.000Z",
"lastCommentDate": "2020-05-18T18:58:30.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44853/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"scrollmagic"
],
"files": [
{
"filePath": "types/scrollmagic/tslint.json",
"kind": "package-meta",
"package": "scrollmagic"
}
],
"hasDismissedReview": false,
"travisResult": "pass",
"lastReviewDate": "2020-05-18T19:03:08.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @switchnollie - please review this PR in the next few days. Be sure to explicitly select |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. scrollmagic (unpkg)was missing the following properties:
The most common way to resolve this error is to use 'export =' syntax.
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
I can't tell from the source whether scrollmagic exports a callable object because all the documentation is for the global usage. However, the global usage is a namespace, not a function, so I suspect the module is the same.
I can't tell from the source whether scrollmagic exports a callable object because all the documentation is for the global usage. However, the global usage is a namespace, not a function, so I suspect the module is the same.
I can't tell from the source whether scrollmagic exports a callable object because all the documentation is for the global usage. However, the global usage is a namespace, not a function, so I suspect the module is the same.