Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing type for redux-sentry-middleware #44988

Merged
merged 1 commit into from May 27, 2020

Conversation

brendanmorrell
Copy link
Contributor

@brendanmorrell brendanmorrell commented May 22, 2020

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 22, 2020

@brendanmorrell Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44988,
  "author": "brendanmorrell",
  "owners": [
    "dolezel"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "0eae033",
  "headCommitOid": "0eae0339fd1c33b34ac314c9d65c26d9c779385e",
  "mergeIsRequested": false,
  "stalenessInDays": 3,
  "lastCommitDate": "2020-05-22T17:24:03.000Z",
  "lastCommentDate": "2020-05-22T17:24:03.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44988/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "redux-sentry-middleware"
  ],
  "files": [
    {
      "filePath": "types/redux-sentry-middleware/index.d.ts",
      "kind": "definition",
      "package": "redux-sentry-middleware"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "pass",
  "lastReviewDate": "2020-05-25T08:55:37.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @dolezel - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board May 22, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 22, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44988 diff
Batch compilation
Memory usage (MiB) 77.6 76.7 -1.3%
Type count 11528 11530 0%
Assignability cache size 34917 34917 0%
Language service
Samples taken 10 10 0%
Identifiers in tests 10 10 0%
getCompletionsAtPosition
    Mean duration (ms) 339.3 347.9 +2.5%
    Mean CV 13.8% 15.2%
    Worst duration (ms) 396.4 403.9 +1.9%
    Worst identifier applyMiddleware middleware
getQuickInfoAtPosition
    Mean duration (ms) 329.5 328.0 -0.4%
    Mean CV 10.8% 11.8% +9.2%
    Worst duration (ms) 398.5 374.7 -6.0%
    Worst identifier createSentryMiddleware applyMiddleware

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label May 22, 2020
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 25, 2020
@amcasey amcasey merged commit ee07761 into DefinitelyTyped:master May 27, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 27, 2020
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants