-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gapi.client.drive] automatic update #45514
[gapi.client.drive] automatic update #45514
Conversation
a4496bc
to
53216f1
Compare
@Maxim-Mazurok Thank you for submitting this PR! This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45514,
"author": "Maxim-Mazurok",
"owners": [
"Maxim-Mazurok"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "76936a8",
"headCommitOid": "76936a8fda59431b10cb28308adb0fc055085694",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-06-23T23:17:02.000Z",
"lastCommentDate": "2020-06-23T23:21:28.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45514/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"gapi.client.drive"
],
"files": [
{
"filePath": "types/gapi.client.drive/index.d.ts",
"kind": "definition",
"package": "gapi.client.drive"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
53216f1
to
76936a8
Compare
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. wordpress__components (unpkg)was missing the following properties:
as well as these 2 other properties...ToolbarGroup, VisuallyHidden |
I just published |
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.🤖 This pull request was automatically created by Maxim-Mazurok/google-api-typings-generator which generates types from Google API Discovery Service. Types were linted and tested before submission.
If there is an issue with this pull request, consider submitting a new issue.
Note you can also use these types from our
types
branch which is updated hourly.