Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gapi.client.drive] automatic update #45514

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Maxim-Mazurok
Copy link
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Maxim-Mazurok/google-api-typings-generator#google-api-typings-generator
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

🤖 This pull request was automatically created by Maxim-Mazurok/google-api-typings-generator which generates types from Google API Discovery Service. Types were linted and tested before submission.

If there is an issue with this pull request, consider submitting a new issue.

Note you can also use these types from our types branch which is updated hourly.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 16, 2020

@Maxim-Mazurok Thank you for submitting this PR!

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ A DT maintainer can merge changes when there are no other reviewers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45514,
  "author": "Maxim-Mazurok",
  "owners": [
    "Maxim-Mazurok"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "76936a8",
  "headCommitOid": "76936a8fda59431b10cb28308adb0fc055085694",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-06-23T23:17:02.000Z",
  "lastCommentDate": "2020-06-23T23:21:28.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45514/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "gapi.client.drive"
  ],
  "files": [
    {
      "filePath": "types/gapi.client.drive/index.d.ts",
      "kind": "definition",
      "package": "gapi.client.drive"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Jun 16, 2020
@typescript-bot typescript-bot added this to Needs Maintainer Review in New Pull Request Status Board Jun 16, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45514 diff
Batch compilation
Memory usage (MiB) 74.2 74.3 +0.2%
Type count 10905 10905 0%
Assignability cache size 3487 3487 0%
Language service
Samples taken 1273 1273 0%
Identifiers in tests 1273 1273 0%
getCompletionsAtPosition
    Mean duration (ms) 270.9 272.6 +0.6%
    Mean CV 9.8% 10.2%
    Worst duration (ms) 360.4 368.0 +2.1%
    Worst identifier viewedByMe properties
getQuickInfoAtPosition
    Mean duration (ms) 275.2 277.2 +0.7%
    Mean CV 10.0% 10.3% +3.4%
    Worst duration (ms) 340.9 389.2 +14.2%
    Worst identifier get kind

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jun 16, 2020
@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Jun 23, 2020
@danger-public
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

wordpress__components (unpkg)

was missing the following properties:

  1. CustomSelectControl
  2. Guide
  3. GuidePage
  4. TextHighlight
  5. Tip
as well as these 2 other properties...

ToolbarGroup, VisuallyHidden

Generated by 🚫 dangerJS against 76936a8

@typescript-bot typescript-bot added the No Other Owners This DT module only has one owner, so we can't have someone verify the change. label Jun 23, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jun 23, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jun 23, 2020
@elibarzilay elibarzilay merged commit cd38047 into DefinitelyTyped:master Jun 24, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jun 24, 2020
@typescript-bot
Copy link
Contributor

I just published @types/gapi.client.drive@3.0.8 to npm.

ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants