Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for json-dup-key-validator #45543

Merged
merged 1 commit into from Jun 21, 2020
Merged

Add types for json-dup-key-validator #45543

merged 1 commit into from Jun 21, 2020

Conversation

JamieMagee
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 17, 2020

@JamieMagee Thank you for submitting this PR!

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45543,
  "author": "JamieMagee",
  "owners": [],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "e1c4487",
  "headCommitOid": "e1c4487f0e140934fa9057fe87f2c84b4b3be942",
  "mergeIsRequested": false,
  "stalenessInDays": 3,
  "lastCommitDate": "2020-06-17T12:29:29.000Z",
  "lastCommentDate": "2020-06-17T12:29:29.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45543/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": true,
  "packages": [
    "json-dup-key-validator"
  ],
  "files": [
    {
      "filePath": "types/json-dup-key-validator/index.d.ts",
      "kind": "definition",
      "package": "json-dup-key-validator"
    },
    {
      "filePath": "types/json-dup-key-validator/json-dup-key-validator-tests.ts",
      "kind": "test",
      "package": "json-dup-key-validator"
    },
    {
      "filePath": "types/json-dup-key-validator/tsconfig.json",
      "kind": "package-meta",
      "package": "json-dup-key-validator"
    },
    {
      "filePath": "types/json-dup-key-validator/tslint.json",
      "kind": "package-meta",
      "package": "json-dup-key-validator"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Jun 17, 2020
@typescript-bot typescript-bot added this to Needs Maintainer Review in New Pull Request Status Board Jun 17, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to json-dup-key-validator with its source on master.

Comparison details 📊
Batch compilation
Type count 2106
Assignability cache size 95
Language service measurements
Samples taken 9
Identifiers in tests 9
getCompletionsAtPosition
    Mean duration (ms) 73.5
    Mean CV 28.1%
    Worst duration (ms) 85.7
    Worst identifier jsonValidator
getQuickInfoAtPosition
    Mean duration (ms) 72.9
    Mean CV 22.0%
    Worst duration (ms) 89.1
    Worst identifier jsonValidator
System information
Node version v12.18.0
CPU count 2
CPU speed 2.095 GHz
CPU model Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1083-azure

@DanielRosenwasser DanielRosenwasser merged commit 1e67ae1 into DefinitelyTyped:master Jun 21, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jun 21, 2020
@typescript-bot
Copy link
Contributor

I just published @types/json-dup-key-validator@1.0.0 to npm.

vanessayuenn pushed a commit to vanessayuenn/DefinitelyTyped that referenced this pull request Jun 23, 2020
JamieMagee added a commit to renovatebot/renovate that referenced this pull request Jun 29, 2020
ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants