New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for changelog-filename-regex #45770
Add types for changelog-filename-regex #45770
Conversation
@JamieMagee Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45770,
"author": "JamieMagee",
"owners": [],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "c353e59",
"headCommitOid": "c353e595fe3af981327b2b89129667dd1019eab3",
"mergeIsRequested": false,
"stalenessInDays": 6,
"lastCommitDate": "2020-06-29T08:38:07.000Z",
"lastCommentDate": "2020-06-29T08:42:31.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45770/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": true,
"packages": [
"changelog-filename-regex"
],
"files": [
{
"filePath": "types/changelog-filename-regex/changelog-filename-regex-tests.ts",
"kind": "test",
"package": "changelog-filename-regex"
},
{
"filePath": "types/changelog-filename-regex/index.d.ts",
"kind": "definition",
"package": "changelog-filename-regex"
},
{
"filePath": "types/changelog-filename-regex/tsconfig.json",
"kind": "package-meta",
"package": "changelog-filename-regex"
},
{
"filePath": "types/changelog-filename-regex/tslint.json",
"kind": "package-meta",
"package": "changelog-filename-regex"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. changelog-filename-regex (unpkg)was missing the following properties:
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to changelog-filename-regex with its source on master. Comparison details 📊
|
I just published |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }
. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.