Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getSorters in tabulator-tables #45957

Merged
merged 1 commit into from Jul 10, 2020
Merged

Update getSorters in tabulator-tables #45957

merged 1 commit into from Jul 10, 2020

Conversation

BryceBarbara
Copy link
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: http://tabulator.info/docs/4.7/sort (scroll down to the "Get Current Sorters" section)
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

This is a pretty straightforward change.

I wasn't able to run npm run lint due to only having access to use the github online editor right now. If that's a problem, I can definitely run it in the future when I regain access to my usual PC. Please let me know if there is anything else I need to do! 😊

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Untested Change This PR does not touch tests labels Jul 8, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 8, 2020

@BryceBarbara Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45957,
  "author": "BryceBarbara",
  "owners": [
    "jojoshua"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5189b9",
  "headCommitOid": "a5189b92873a07ecc865b4bc17c5c09ce9034a49",
  "mergeIsRequested": false,
  "stalenessInDays": 1,
  "lastPushDate": "2020-07-08T17:08:03.000Z",
  "lastCommentDate": "2020-07-08T21:27:51.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45957/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "tabulator-tables"
  ],
  "files": [
    {
      "path": "types/tabulator-tables/index.d.ts",
      "kind": "definition",
      "package": "tabulator-tables"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-08T18:41:07.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @Jojoshua - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jul 8, 2020
@typescript-bot typescript-bot moved this from Other to Needs Maintainer Review in New Pull Request Status Board Jul 8, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45957 diff
Batch compilation
Memory usage (MiB) 76.6 76.7 +0.1%
Type count 11981 11982 0%
Assignability cache size 3781 3781 0%
Language service
Samples taken 921 921 0%
Identifiers in tests 921 921 0%
getCompletionsAtPosition
    Mean duration (ms) 336.3 336.2 0.0%
    Mean CV 9.6% 9.4%
    Worst duration (ms) 458.9 455.6 -0.7%
    Worst identifier response then
getQuickInfoAtPosition
    Mean duration (ms) 339.1 339.3 +0.1%
    Mean CV 9.7% 9.7% +0.2%
    Worst duration (ms) 431.1 445.3 +3.3%
    Worst identifier minHeight then

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 8, 2020
Copy link
Contributor

@Jojoshua Jojoshua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 8, 2020
@Jojoshua
Copy link
Contributor

Jojoshua commented Jul 8, 2020

@BryceBarbara I think if you add a test for this then the TS bot will let you auto-merge the changes.

@weswigham weswigham merged commit 1d07531 into DefinitelyTyped:master Jul 10, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jul 10, 2020
ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants