New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getSorters in tabulator-tables #45957
Conversation
@BryceBarbara Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45957,
"author": "BryceBarbara",
"owners": [
"jojoshua"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "a5189b9",
"headCommitOid": "a5189b92873a07ecc865b4bc17c5c09ce9034a49",
"mergeIsRequested": false,
"stalenessInDays": 1,
"lastPushDate": "2020-07-08T17:08:03.000Z",
"lastCommentDate": "2020-07-08T21:27:51.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45957/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Well-liked by everyone",
"anyPackageIsNew": false,
"packages": [
"tabulator-tables"
],
"files": [
{
"path": "types/tabulator-tables/index.d.ts",
"kind": "definition",
"package": "tabulator-tables"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-07-08T18:41:07.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @Jojoshua - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@BryceBarbara I think if you add a test for this then the TS bot will let you auto-merge the changes. |
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.This is a pretty straightforward change.
I wasn't able to run
npm run lint
due to only having access to use the github online editor right now. If that's a problem, I can definitely run it in the future when I regain access to my usual PC. Please let me know if there is anything else I need to do! 😊