Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type definitions for "nuclear-js-react-addons-chefsplate" module #46011

Merged
merged 3 commits into from Jul 12, 2020

Conversation

patlillis
Copy link
Contributor

@patlillis patlillis commented Jul 10, 2020

NOTE: I only added types for connect(), and left the other exports as any. I only use connect() in my own code, so that's the only one I care about having types for.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@patlillis patlillis marked this pull request as ready for review July 10, 2020 22:03
@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Jul 10, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 10, 2020

@patlillis Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 46011,
  "author": "patlillis",
  "owners": [],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "eda3e86",
  "headCommitOid": "eda3e86e18a33c834401e58e1743c3aafde1dbe6",
  "mergeIsRequested": false,
  "stalenessInDays": 1,
  "lastPushDate": "2020-07-10T22:54:23.000Z",
  "reopenedDate": "2020-07-10T22:03:48.000Z",
  "lastCommentDate": "2020-07-10T22:54:23.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46011/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": true,
  "packages": [
    "nuclear-js-react-addons-chefsplate"
  ],
  "files": [
    {
      "path": "types/nuclear-js-react-addons-chefsplate/index.d.ts",
      "kind": "definition",
      "package": "nuclear-js-react-addons-chefsplate"
    },
    {
      "path": "types/nuclear-js-react-addons-chefsplate/nuclear-js-react-addons-chefsplate-tests.tsx",
      "kind": "test",
      "package": "nuclear-js-react-addons-chefsplate"
    },
    {
      "path": "types/nuclear-js-react-addons-chefsplate/tsconfig.json",
      "kind": "package-meta",
      "package": "nuclear-js-react-addons-chefsplate"
    },
    {
      "path": "types/nuclear-js-react-addons-chefsplate/tslint.json",
      "kind": "package-meta-ok",
      "package": "nuclear-js-react-addons-chefsplate"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jul 10, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 10, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to nuclear-js-react-addons-chefsplate with its source on master.

Comparison details 📊
Batch compilation
Type count 16112
Assignability cache size 3456
Language service measurements
Samples taken 140
Identifiers in tests 140
getCompletionsAtPosition
    Mean duration (ms) 319.0
    Mean CV 10.1%
    Worst duration (ms) 439.1
    Worst identifier ConnectedCCWithoutOptionalProp
getQuickInfoAtPosition
    Mean duration (ms) 310.3
    Mean CV 9.9%
    Worst duration (ms) 451.2
    Worst identifier optional
System information
Node version v12.18.1
CPU count 2
CPU speed 2.095 GHz
CPU model Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1089-azure

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Maintainer Action in New Pull Request Status Board Jul 11, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Maintainer Review in New Pull Request Status Board Jul 11, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Maintainer Action in New Pull Request Status Board Jul 11, 2020
@typescript-bot
Copy link
Contributor

🔔 @patlillis — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Maintainer Review in New Pull Request Status Board Jul 12, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Maintainer Action in New Pull Request Status Board Jul 12, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Maintainer Review in New Pull Request Status Board Jul 12, 2020
@weswigham weswigham merged commit 322ea30 into DefinitelyTyped:master Jul 12, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jul 12, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
…efinitelyTyped#46011)

* add type definitions for nuclear-js-react-addons-chefsplate module

* make tsline disable inline

* remove unnecessary generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants