mailgun-js: Adds delete method to mailinglists

[gstvds]

Adds missing delete method for mailing lists inside lists method. It also adds a new return type to match correct the delete return type.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <https://documentation.mailgun.com/en/latest/api-mailinglists.html?highlight=delete%20list#examples> topic Remove mailing list

[typescript-bot]

@gstvds Thank you for submitting this PR!

This is a live comment which I will keep updated.

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 46373,
  "author": "gstvds",
  "owners": [
    "sampsonjoliver",
    "andipaetzold",
    "JiriBalcar",
    "CodeLenny"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "600fb9a",
  "headCommitOid": "600fb9afd0768984c0d6bcf2136361f7e3139d90",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-07-27T16:36:16.000Z",
  "lastCommentDate": "2020-07-27T17:05:09.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46373/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "mailgun-js"
  ],
  "files": [
    {
      "path": "types/mailgun-js/index.d.ts",
      "kind": "definition",
      "package": "mailgun-js"
    },
    {
      "path": "types/mailgun-js/mailgun-js-tests.ts",
      "kind": "test",
      "package": "mailgun-js"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-27T17:02:19.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 1,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @sampsonjoliver @andipaetzold @JiriBalcar @CodeLenny — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@gstvds Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#46373	diff
Batch compilation
Memory usage (MiB)	67.3	66.9	-0.7%
Type count	9126	9133	0%
Assignability cache size	1653	1655	0%
Language service
Samples taken	190	190	0%
Identifiers in tests	190	190	0%
getCompletionsAtPosition
Mean duration (ms)	319.2	322.2	+0.9%
Mean CV	10.9%	10.8%
Worst duration (ms)	388.0	409.6	+5.6%
Worst identifier	get	mailgun
getQuickInfoAtPosition
Mean duration (ms)	323.0	327.1	+1.3%
Mean CV	12.1%	12.3%	+2.1%
Worst duration (ms)	403.0	398.4	-1.1%
Worst identifier	data	mailgun

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[brendonhc]

Perfect!! I need these types a lot, thanks

[typescript-bot]

@gstvds Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@sampsonjoliver, @andipaetzold, @JiriBalcar, @CodeLenny: you can do this too.)

[gstvds]

Ready to merge