New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(react-helmet): 6.1 ES exports changes #46509
update(react-helmet): 6.1 ES exports changes #46509
Conversation
This commit updates definition by: - adding support for 6.1 change introducing named and default exports support (this fixes errorrs like ` JSX element type 'Helmet' does not have any construct or call signatures.` - minor version bump - maintainer added nfl/react-helmet#547 https://github.com/nfl/react-helmet/releases/tag/6.1.0 Thanks!
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 46509,
"author": "peterblazejewicz",
"owners": [
"evanbb",
"isman-usoh",
"lith-light-g",
"sammkj",
"yuit",
"ykzts",
"wKovacs64",
"Andriy2"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "e741fc3",
"headCommitOid": "e741fc350de95d83b6f2e9d84ea51179bf3e44be",
"mergeIsRequested": true,
"stalenessInDays": 0,
"lastPushDate": "2020-08-02T15:22:43.000Z",
"lastCommentDate": "2020-08-03T19:10:42.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46509/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"react-helmet"
],
"files": [
{
"path": "types/react-helmet/index.d.ts",
"kind": "definition",
"package": "react-helmet"
},
{
"path": "types/react-helmet/react-helmet-tests.tsx",
"kind": "test",
"package": "react-helmet"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-08-02T21:48:02.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @evanbb @isman-usoh @lith-light-g @sammkj @yuit @ykzts @wKovacs64 @andriy2 — please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@evanbb, @isman-usoh, @lith-light-g, @sammkj, @yuit, @ykzts, @wKovacs64, @andriy2: you can do this too.) |
Ready to merge 🛴 |
… changes by @peterblazejewicz This commit updates definition by: - adding support for 6.1 change introducing named and default exports support (this fixes errorrs like ` JSX element type 'Helmet' does not have any construct or call signatures.` - minor version bump - maintainer added nfl/react-helmet#547 https://github.com/nfl/react-helmet/releases/tag/6.1.0 Thanks!
This commit updates definition by:
support (this fixes errorrs like
JSX element type 'Helmet' does not have any construct or call signatures.
nfl/react-helmet#547
https://github.com/nfl/react-helmet/releases/tag/6.1.0
Thanks!
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).