-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added typing for "validate" function added in uuid release 8.3.0 #46557
Conversation
@dcgudeman Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 46557,
"author": "dcgudeman",
"owners": [
"iamolivinius",
"felipeochoa",
"cjbarth",
"LinusU",
"ctavan"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "a879b2c",
"headCommitOid": "a879b2c65cc79fa82a37f1f790565f974e1f3c34",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-08-05T00:38:15.000Z",
"lastCommentDate": "2020-08-05T00:38:15.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46557/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"uuid"
],
"files": [
{
"path": "types/uuid/index.d.ts",
"kind": "definition",
"package": "uuid"
},
{
"path": "types/uuid/interfaces.d.ts",
"kind": "definition",
"package": "uuid"
},
{
"path": "types/uuid/uuid-tests.ts",
"kind": "test",
"package": "uuid"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @iamolivinius @felipeochoa @cjbarth @LinusU @ctavan — please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
…3.0 (DefinitelyTyped#46557)" This reverts commit c50f120.
…3.0 (DefinitelyTyped#46557)" This reverts commit c50f120.
…3.0 (DefinitelyTyped#46557)" This reverts commit c50f120.
* Revert "added typing for "validate" function added in uuid release 8.3.0 (DefinitelyTyped#46557)" This reverts commit c50f120. * Upgrade types for uuid@8.3.0 * Export v1/v4 options
…initelyTyped#46557) * added type for validation function and added test * added type for validation function and added test. Forgot to add changes in last commit
* Revert "added typing for "validate" function added in uuid release 8.3.0 (DefinitelyTyped#46557)" This reverts commit c50f120. * Upgrade types for uuid@8.3.0 * Export v1/v4 options
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }
. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.If removing a declaration:
notNeededPackages.json
.