New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yargs] Example can take an array of args #47885
[yargs] Example can take an array of args #47885
Conversation
@NathanYocum Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47885,
"author": "NathanYocum",
"owners": [
"poelstra",
"mizunashi-mana",
"pushplay",
"jeffkenney",
"JimiC",
"steffenvv",
"forivall",
"ExE-Boss",
"Aankhen"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "b691b4a",
"headCommitOid": "b691b4a0741a7d8d7a3bd4e50e5fa5eda7d8f4cc",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-09-23T01:29:00.000Z",
"lastCommentDate": "2020-09-23T01:24:28.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47885/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"newPackages": [],
"packages": [
"yargs"
],
"files": [
{
"path": "types/yargs/index.d.ts",
"kind": "definition",
"package": "yargs"
},
{
"path": "types/yargs/yargs-tests.ts",
"kind": "test",
"package": "yargs"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-09-23T01:33:38.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
🔔 @poelstra @mizunashi-mana @pushplay @jeffkenney @JimiC @steffenvv @forivall @ExE-Boss @Aankhen — please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It just needs a bit of clean up.
@NathanYocum One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. If you disagree with the reviewer's comments, you can "dismiss" the review using GitHub's review UI. Thank you! |
@pushplay Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for the changes.
npm test yargs
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition: