Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[woocommerce__woocommerce-rest-api] Unmangle scoped package names #48236

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Sep 26, 2020

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Sep 26, 2020
@jablko jablko force-pushed the unmangle/woocommerce__woocommerce-rest-api branch from 76181d6 to b4d71f6 Compare September 27, 2020 17:25
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #48236 diff
Batch compilation
Memory usage (MiB) 36.9 37.3 +1.0%
Type count 2190 2190 0%
Assignability cache size 100 100 0%
Language service
Samples taken 48 48 0%
Identifiers in tests 48 48 0%
getCompletionsAtPosition
    Mean duration (ms) 107.1 107.3 +0.2%
    Mean CV 26.1% 24.3%
    Worst duration (ms) 127.2 142.8 +12.3%
    Worst identifier delete Promise
getQuickInfoAtPosition
    Mean duration (ms) 105.2 106.0 +0.8%
    Mean CV 25.5% 23.7% -7.2%
    Worst duration (ms) 130.9 133.3 +1.8%
    Worst identifier Promise delete

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Sep 27, 2020
@jablko jablko marked this pull request as ready for review September 27, 2020 19:03
@typescript-bot typescript-bot added the Check Config Changes a module config files label Sep 27, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Sep 27, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 27, 2020

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 7 days — please merge or say something if there's a problem, otherwise it will move to the DT maintainer queue soon!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 48236,
  "author": "jablko",
  "owners": [
    "climba03003"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "b4d71f6",
  "headCommitOid": "b4d71f672f0f204a514002348ebc2025d18866ca",
  "mergeIsRequested": true,
  "stalenessInDays": 7,
  "lastPushDate": "2020-09-27T17:25:18.000Z",
  "reopenedDate": "2020-09-27T19:03:37.000Z",
  "lastCommentDate": "2020-10-02T18:45:57.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48236/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "woocommerce__woocommerce-rest-api"
  ],
  "files": [
    {
      "path": "types/woocommerce__woocommerce-rest-api/tsconfig.json",
      "kind": "package-meta-ok",
      "package": "woocommerce__woocommerce-rest-api"
    },
    {
      "path": "types/woocommerce__woocommerce-rest-api/woocommerce__woocommerce-rest-api-tests.ts",
      "kind": "test",
      "package": "woocommerce__woocommerce-rest-api"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-09T07:37:37.000Z",
  "firstApprovalDate": "2020-09-30T00:07:50.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 7,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @climba03003 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Sep 27, 2020
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 30, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Sep 30, 2020
@typescript-bot
Copy link
Contributor

@jablko Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@climba03003: you can do this too.)

@jablko
Copy link
Contributor Author

jablko commented Oct 2, 2020

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 2, 2020
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Oct 9, 2020
elibarzilay pushed a commit to jablko/dt-mergebot that referenced this pull request Oct 16, 2020
Since DefinitelyTyped#190 we ignore "ready to merge" comments predating the most recent
review. That change explicitly discounts the most recent comment date,
so additional comments don't trample the "ready to merge" request,
however additional approvals still do:
DefinitelyTyped/DefinitelyTyped#48236

We can't drop the `lastReviewDate` from the `sinceDates` entirely
without reopening DefinitelyTyped#164, demonstrated in
DefinitelyTyped/DefinitelyTyped#46120, so the next simplest thing is to
replace it with the earliest (non-stale) approval date.

This works for DefinitelyTyped/DefinitelyTyped#46120 (continues to
ignore requests preceding approval) and
DefinitelyTyped/DefinitelyTyped#48236 (additional approvals don't
trample requests, like additional comments don't).
elibarzilay pushed a commit to DefinitelyTyped/dt-mergebot that referenced this pull request Oct 16, 2020
Since #190 we ignore "ready to merge" comments predating the most recent
review. That change explicitly discounts the most recent comment date,
so additional comments don't trample the "ready to merge" request,
however additional approvals still do:
DefinitelyTyped/DefinitelyTyped#48236

We can't drop the `lastReviewDate` from the `sinceDates` entirely
without reopening #164, demonstrated in
DefinitelyTyped/DefinitelyTyped#46120, so the next simplest thing is to
replace it with the earliest (non-stale) approval date.

This works for DefinitelyTyped/DefinitelyTyped#46120 (continues to
ignore requests preceding approval) and
DefinitelyTyped/DefinitelyTyped#48236 (additional approvals don't
trample requests, like additional comments don't).
@typescript-bot typescript-bot removed the Check Config Changes a module config files label Oct 17, 2020
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 17, 2020
@typescript-bot typescript-bot merged commit b380786 into DefinitelyTyped:master Oct 17, 2020
@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants