-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[woocommerce__woocommerce-rest-api] Unmangle scoped package names #48236
[woocommerce__woocommerce-rest-api] Unmangle scoped package names #48236
Conversation
76181d6
to
b4d71f6
Compare
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@jablko Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. InactiveThis PR has been inactive for 7 days — please merge or say something if there's a problem, otherwise it will move to the DT maintainer queue soon! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 48236,
"author": "jablko",
"owners": [
"climba03003"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "b4d71f6",
"headCommitOid": "b4d71f672f0f204a514002348ebc2025d18866ca",
"mergeIsRequested": true,
"stalenessInDays": 7,
"lastPushDate": "2020-09-27T17:25:18.000Z",
"reopenedDate": "2020-09-27T19:03:37.000Z",
"lastCommentDate": "2020-10-02T18:45:57.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48236/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"newPackages": [],
"packages": [
"woocommerce__woocommerce-rest-api"
],
"files": [
{
"path": "types/woocommerce__woocommerce-rest-api/tsconfig.json",
"kind": "package-meta-ok",
"package": "woocommerce__woocommerce-rest-api"
},
{
"path": "types/woocommerce__woocommerce-rest-api/woocommerce__woocommerce-rest-api-tests.ts",
"kind": "test",
"package": "woocommerce__woocommerce-rest-api"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-10-09T07:37:37.000Z",
"firstApprovalDate": "2020-09-30T00:07:50.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 7,
"isChangesRequested": false
} |
🔔 @climba03003 — please review this PR in the next few days. Be sure to explicitly select |
@jablko Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@climba03003: you can do this too.) |
Ready to merge |
Since DefinitelyTyped#190 we ignore "ready to merge" comments predating the most recent review. That change explicitly discounts the most recent comment date, so additional comments don't trample the "ready to merge" request, however additional approvals still do: DefinitelyTyped/DefinitelyTyped#48236 We can't drop the `lastReviewDate` from the `sinceDates` entirely without reopening DefinitelyTyped#164, demonstrated in DefinitelyTyped/DefinitelyTyped#46120, so the next simplest thing is to replace it with the earliest (non-stale) approval date. This works for DefinitelyTyped/DefinitelyTyped#46120 (continues to ignore requests preceding approval) and DefinitelyTyped/DefinitelyTyped#48236 (additional approvals don't trample requests, like additional comments don't).
Since #190 we ignore "ready to merge" comments predating the most recent review. That change explicitly discounts the most recent comment date, so additional comments don't trample the "ready to merge" request, however additional approvals still do: DefinitelyTyped/DefinitelyTyped#48236 We can't drop the `lastReviewDate` from the `sinceDates` entirely without reopening #164, demonstrated in DefinitelyTyped/DefinitelyTyped#46120, so the next simplest thing is to replace it with the earliest (non-stale) approval date. This works for DefinitelyTyped/DefinitelyTyped#46120 (continues to ignore requests preceding approval) and DefinitelyTyped/DefinitelyTyped#48236 (additional approvals don't trample requests, like additional comments don't).
I just published |
#47115