[d3-color] Bump types to v1.4

[Methuselah96]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/d3/d3-color/releases/tag/v1.4.0
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

Related: #38939

[typescript-bot]

@Methuselah96 Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

1 package in this PR

• d3-color on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48329,
  "author": "Methuselah96",
  "owners": [
    "tomwanzek",
    "gustavderdrache",
    "borisyankov",
    "denisname",
    "ledragon",
    "Methuselah96"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "ceb09be",
  "headCommitOid": "ceb09be35b85c79b7c6096cbfe4c00c71faa9dca",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-30T00:14:27.000Z",
  "lastCommentDate": "2020-09-30T19:30:39.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48329/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "newPackages": [],
  "packages": [
    "d3-color"
  ],
  "files": [
    {
      "path": "types/d3-color/index.d.ts",
      "kind": "definition",
      "package": "d3-color"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-09-30T19:27:23.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 4,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @tomwanzek @gustavderdrache @borisyankov @denisname @Ledragon — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#48329	diff
Batch compilation
Memory usage (MiB)	76.5	78.0	+2.0%
Type count	10426	10426	0%
Assignability cache size	3484	3484	0%
Language service
Samples taken	454	454	0%
Identifiers in tests	454	454	0%
getCompletionsAtPosition
Mean duration (ms)	443.4	437.5	-1.3%
Mean CV	8.7%	8.3%
Worst duration (ms)	527.5	550.7	+4.4%
Worst identifier	cLab	color
getQuickInfoAtPosition
Mean duration (ms)	436.3	430.8	-1.3%
Mean CV	8.6%	8.7%	+0.9%
Worst duration (ms)	529.4	508.2	-4.0%
Worst identifier	hcl	cString

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@Methuselah96 Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tomwanzek, @gustavderdrache, @borisyankov, @denisname, @Ledragon: you can do this too.)

[Methuselah96]

Ready to merge

[typescript-bot]

I just published @types/d3-color@1.4.0 to npm.