Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-manifest-plugin: Update for 3.0 #50049

Closed

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Dec 10, 2020

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/shellscape/webpack-manifest-plugin/releases/tag/v3.0.0
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 10, 2020
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 10, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 10, 2020

@andersk Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ❌ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 50049,
  "author": "andersk",
  "headCommitAbbrOid": "e86d93d",
  "headCommitOid": "e86d93da5e03f468a407b88e4f870bbd2ad22e03",
  "lastPushDate": "2020-12-10T00:28:13.000Z",
  "lastActivityDate": "2020-12-10T00:28:13.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "webpack-manifest-plugin",
      "kind": "edit",
      "files": [
        {
          "path": "types/webpack-manifest-plugin/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/webpack-manifest-plugin/webpack-manifest-plugin-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "r3nya",
        "monsonjeremy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @r3nya @monsonjeremy — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a version of webpack-manifest-plugin that doesn’t yet exist on master, so I’ve compared them with v2.1.

Comparison details 📊
2.1@master 3.0 in #50049 diff
Batch compilation
Memory usage (MiB) 75.1 76.8 +2.3%
Type count 11072 11072 0%
Assignability cache size 1948 1947 0%
Language service
Samples taken 67 69 +3%
Identifiers in tests 67 69 +3%
getCompletionsAtPosition
    Mean duration (ms) 366.6 361.6 -1.3%
    Mean CV 13.1% 12.0%
    Worst duration (ms) 478.5 431.2 -9.9%
    Worst identifier reduce path
getQuickInfoAtPosition
    Mean duration (ms) 376.0 361.1 -4.0%
    Mean CV 12.6% 10.8%
    Worst duration (ms) 459.0 442.4 -3.6%
    Worst identifier reduce manifest

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Dec 10, 2020
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Dec 11, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Dec 11, 2020
@typescript-bot
Copy link
Contributor

@andersk Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@andersk andersk closed this Dec 11, 2020
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Dec 11, 2020
@andersk
Copy link
Contributor Author

andersk commented Dec 11, 2020

Looks like this was replaced with #50071 and #50074, which were submitted later.

@andersk andersk deleted the webpack-manifest-plugin branch March 18, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants