-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack-manifest-plugin: Update for 3.0 #50049
Conversation
@andersk Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 50049,
"author": "andersk",
"headCommitAbbrOid": "e86d93d",
"headCommitOid": "e86d93da5e03f468a407b88e4f870bbd2ad22e03",
"lastPushDate": "2020-12-10T00:28:13.000Z",
"lastActivityDate": "2020-12-10T00:28:13.000Z",
"maintainerBlessed": false,
"hasMergeConflict": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "webpack-manifest-plugin",
"kind": "edit",
"files": [
{
"path": "types/webpack-manifest-plugin/index.d.ts",
"kind": "definition"
},
{
"path": "types/webpack-manifest-plugin/webpack-manifest-plugin-tests.ts",
"kind": "test"
}
],
"owners": [
"r3nya",
"monsonjeremy"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"ciResult": "pass"
} |
🔔 @r3nya @monsonjeremy — please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? These typings are for a version of webpack-manifest-plugin that doesn’t yet exist on master, so I’ve compared them with v2.1. Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
87e37c1
to
1806d2e
Compare
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1806d2e
to
e86d93d
Compare
@andersk Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
Please fill in this template.
npm test <package to test>
.If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.