fix(express): Add package.json for express

[quinnturner]

Adds a versioned dependency for @types/express for @types/express-serve-static-core ^4.17.18.
This fixes a breaking typing issue for @types/4.17.10 where it strictly requires @types/express-serve-static-core ^4.17.18.
Otherwise, all properties on Request are not defined.

Please review the existing discussion on this thread: #50390

We might be required to modify: https://github.com/microsoft/DefinitelyTyped-tools/blob/master/packages/definitions-parser/allowedPackageJsonDependencies.txt Modification merged.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

[typescript-bot]

@quinnturner Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• express on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 50554,
  "author": "quinnturner",
  "headCommitOid": "bb385e1224e07264d5aef8e63a8c077b79219298",
  "lastPushDate": "2021-01-12T19:10:53.000Z",
  "lastActivityDate": "2021-01-12T19:24:34.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "express",
      "kind": "edit",
      "files": [
        {
          "path": "types/express/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "borisyankov",
        "CMUH",
        "puneetar",
        "dfrankland"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "andrewbranch",
      "date": "2021-01-12T17:31:12.000Z",
      "abbrOid": "f45cfc4"
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @borisyankov @CMUH @puneetar @dfrankland — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@quinnturner The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[andrewbranch]

Remove the others and add this one here: https://github.com/microsoft/DefinitelyTyped-tools/blob/master/packages/definitions-parser/allowedPackageJsonDependencies.txt

[quinnturner]

I was thinking that as well, glad I got the second opinion. Thanks!

[typescript-bot]

@quinnturner The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[quinnturner]

Submitted a request on allowedPackageJsonDependencies

microsoft/DefinitelyTyped-tools#193

[danger-public]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

express (unpkg)

was missing the following properties:

1. Route

Generated by 🚫 dangerJS against bb385e1

[typescript-bot]

@andrewbranch Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[andrewbranch]

@AndrewLeedham, can you sign off?

[AndrewLeedham]

Yes this looks good to me

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#50554	diff
Batch compilation
Memory usage (MiB)	78.2	78.3	+0.1%
Type count	13165	13165	0%
Assignability cache size	2633	2633	0%
Language service
Samples taken	476	476	0%
Identifiers in tests	476	476	0%
getCompletionsAtPosition
Mean duration (ms)	389.4	396.6	+1.8%
Mean CV	9.1%	9.2%
Worst duration (ms)	881.4	860.2	-2.4%
Worst identifier	req	req
getQuickInfoAtPosition
Mean duration (ms)	410.7	417.8	+1.7%
Mean CV	8.7%	8.7%
Worst duration (ms)	836.4	867.7	+3.8%
Worst identifier	get	use

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

I just published @types/express@4.17.11 to npm.

[quinnturner]

Tested, here's my current yarn.lock:

"@types/express@*", "@types/express@^4.17.11":
  version "4.17.11"
  dependencies:
    "@types/body-parser" "*"
    "@types/express-serve-static-core" "^4.17.18"
    "@types/qs" "*"
    "@types/serve-static" "*"

LGTM ✅