-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR to update chai.d.ts to latest chai (chai@3.2.0) #5081
Conversation
Excellent work! But you need to rename the existing chai.d.ts file to chai-2.0.0.d.ts. See http://definitelytyped.org/guides/contributing.html#version Then, squash your changes and I'll give you a thumbs up. |
Done. Sorry for the delay. |
Sorry, @olivr70, but can we also preserve the 2.0 tests? You can see https://github.com/borisyankov/DefinitelyTyped/tree/master/jasmine for an example of how it's organized. Sorry I didn't mention the tests before. |
PR to update chai.d.ts to latest chai (chai@3.2.0)
Hi everyone,
Chai has changed a lot lately, and many intersting features were missing.
Support added for : all, any, fail, ownPropertyDescriptor, frozen, sealed, extensible, NaN, isAbove, isBelow, sameDeepMembers
Updated some assertions : keys(Object), matches
Added new aliases : contains, includes, isOk, isNotOk
chai-tests.ts was updated accordingly.
I also added a subfolder tests. It contains effective mocha tests.
To run those tests :
The problem is that this directory is reported as "typing without test" and the npm test report marks it as failed. 2 options there :
Hope this helps