Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial updates for lodash to 3.10.0 #5094

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

mdekrey
Copy link
Contributor

@mdekrey mdekrey commented Jul 27, 2015

Updates for lodash according to docs and usage:

@tjoskar
Copy link
Contributor

tjoskar commented Jul 27, 2015

Hi,

Can you add _.defaultsDeep aswell?

Should not be more than (and some tests of curse):

//_.defaultsDeep
interface LoDashStatic {
    /**
    * This method is like _.defaults except that it recursively assigns default properties.
    * @param object The destination object.
    * @param sources The source objects.
    * @return The destination object.
    **/
    defaultsDeep<T, TResult>(
        object: T,
        ...sources: any[]): TResult;
}

interface LoDashObjectWrapper<T> {
    /**
    * @see _.defaultsDeep
    **/
    defaultsDeep<T, TResult>(...sources: any[]): LoDashObjectWrapper<TResult>
}

I can create a pull request to your branch if you want.

@tjoskar
Copy link
Contributor

tjoskar commented Jul 28, 2015

Never mind, it already exist a pull request for default deep: #5072

@vvakame
Copy link
Member

vvakame commented Jul 28, 2015

lodash/lodash.d.ts

to author(@bczengel). could you review this PR?
👍 or 👎?

check list

  • pass the Travic-CI test?

@bczengel
Copy link
Contributor

👍

vvakame added a commit that referenced this pull request Aug 17, 2015
Partial updates for lodash to 3.10.0
@vvakame vvakame merged commit cd1bf73 into DefinitelyTyped:master Aug 17, 2015
@vvakame
Copy link
Member

vvakame commented Aug 17, 2015

@bczengel thanks!
@mdekrey thanks mate!

@mdekrey
Copy link
Contributor Author

mdekrey commented Aug 24, 2015

@vvakame Glad to be of service!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants