Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

office-js office-js-preview description fix #51251

Merged
merged 1 commit into from
Feb 16, 2021
Merged

office-js office-js-preview description fix #51251

merged 1 commit into from
Feb 16, 2021

Conversation

Rick-Kirkham
Copy link
Collaborator

Please fill in this template.

If changing an existing definition:

Fixes OfficeDev/office-js-docs-reference#888

@typescript-bot typescript-bot added Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Feb 16, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 16, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 16, 2021

@Rick-Kirkham Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 51251,
  "author": "Rick-Kirkham",
  "headCommitOid": "a564243323b0151c187c0bbf4ac80b8544fd59dd",
  "lastPushDate": "2021-02-16T01:22:20.000Z",
  "lastActivityDate": "2021-02-16T17:00:38.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "sumurthy",
        "alison-mk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "sumurthy",
        "alison-mk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "AlexJerabek",
      "date": "2021-02-16T17:00:38.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @AlexJerabek @ElizabethSamuel-MSFT @sumurthy @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #51251 diff
Batch compilation
Memory usage (MiB) 127.1 127.2 +0.1%
Type count 20924 20924 0%
Assignability cache size 3788 3788 0%
Language service
Samples taken 568 568 0%
Identifiers in tests 568 568 0%
getCompletionsAtPosition
    Mean duration (ms) 868.3 886.5 +2.1%
    Mean CV 7.7% 7.3%
    Worst duration (ms) 1143.5 1043.9 -8.7%
    Worst identifier OfficeExtension OfficeExtension
getQuickInfoAtPosition
    Mean duration (ms) 864.7 884.6 +2.3%
    Mean CV 7.4% 7.0%
    Worst duration (ms) 1046.2 1024.6 -2.1%
    Worst identifier Error sync

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 16, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Feb 16, 2021
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Feb 16, 2021
@Rick-Kirkham Rick-Kirkham merged commit 0ba05ca into DefinitelyTyped:master Feb 16, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Feb 16, 2021
@typescript-bot
Copy link
Contributor

I just published @types/office-js@1.0.163 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/office-js-preview@1.0.197 to npm.

ansu5555 pushed a commit to ansu5555/DefinitelyTyped that referenced this pull request Feb 19, 2021
kaznovac pushed a commit to kaznovac/DefinitelyTyped that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height description has the word width
3 participants