[@types/indy-sdk] add more detailed ledger response types

[TimoGlastra]

Signed-off-by: Timo Glastra timo@animo.id

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/hyperledger/indy-node/blob/master/docs/source/requests.md#requests
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@TimoGlastra Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• indy-sdk on npm, on unpkg (author is owner)
  • owner-approval: @jakubkoci

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 51685,
  "author": "TimoGlastra",
  "headCommitOid": "83cca3c7fe181276c49991ef47e32f272cb792f1",
  "lastPushDate": "2021-03-11T14:00:18.000Z",
  "lastActivityDate": "2021-03-11T17:09:17.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-03-11T17:07:57.000Z",
  "mergeRequestDate": "2021-03-11T17:09:17.000Z",
  "mergeRequestUser": "TimoGlastra",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "indy-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/indy-sdk/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/indy-sdk/indy-sdk-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "TimoGlastra",
        "jakubkoci"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakubkoci",
      "date": "2021-03-11T17:07:20.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @jakubkoci — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[TimoGlastra]

@jakubkoci this adds more detailed response types for ledger requests. We aren't correctly parsing ledger rejections in the framework, so it get's silently ignored and later on creates issues. Logging for the win!

[typescript-bot]

@TimoGlastra The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#51685	diff
Batch compilation
Memory usage (MiB)	69.7	69.1	-0.8%
Type count	9724	9824	+1%
Assignability cache size	1828	1839	+1%
Language service
Samples taken	253	316	+25%
Identifiers in tests	253	316	+25%
getCompletionsAtPosition
Mean duration (ms)	383.7	382.5	-0.3%
Mean CV	10.1%	9.1%
Worst duration (ms)	488.5	490.5	+0.4%
Worst identifier	self_attested_attributes	Buffer
getQuickInfoAtPosition
Mean duration (ms)	385.3	388.3	+0.8%
Mean CV	9.1%	9.1%
Worst duration (ms)	477.1	503.5	+5.5%
Worst identifier	from	from

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@TimoGlastra Everything looks good here. Great job! I am ready to merge this PR (at 83cca3c) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jakubkoci: you can do this too.)

[TimoGlastra]

Ready to merge

[typescript-bot]

I just published @types/indy-sdk@1.15.2 to npm.