[koa-subdomain] Added Types for koa-subdomain

[BolZer]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

[typescript-bot]

@BolZer Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• koa-subdomain (new!) on npm, on unpkg
  • 1 added owner: ✎@BolZer

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52090,
  "author": "BolZer",
  "headCommitOid": "252a1402a0109eb704ed0bb571994f3446781954",
  "lastPushDate": "2021-03-30T18:22:26.000Z",
  "lastActivityDate": "2021-03-30T21:53:37.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-03-30T21:54:12.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "koa-subdomain",
      "kind": "add",
      "files": [
        {
          "path": "types/koa-subdomain/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/koa-subdomain/koa-subdomain-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/koa-subdomain/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/koa-subdomain/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "BolZer"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2021-03-30T21:53:37.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "martin-badin",
      "date": "2021-03-30T19:03:48.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @BolZer — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to koa-subdomain with its source on master.

Comparison details 📊

Batch compilation
Type count	12465
Assignability cache size	2658
Language service measurements
Samples taken	24
Identifiers in tests	24
getCompletionsAtPosition
Mean duration (ms)	403.0
Mean CV	11.4%
Worst duration (ms)	476.4
Worst identifier	listen
getQuickInfoAtPosition
Mean duration (ms)	412.3
Mean CV	12.3%
Worst duration (ms)	446.4
Worst identifier	Router
System information
Node version	v14.16.0
CPU count	2
CPU speed	2.394 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture	x64
Memory	6.8 GiB
Platform	linux
Release	4.15.0-1109-azure

[typescript-bot]

@BolZer One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@martin-badin Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[BolZer]

Ready to merge

[andrewbranch]

@typescript-bot ahem ☝️

[typescript-bot]

I just published @types/koa-subdomain@3.0.0 to npm.