New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[koa-joi-router] Update maxBody type to match documentation and dependency type #52600
[koa-joi-router] Update maxBody type to match documentation and dependency type #52600
Conversation
Hey @kstolp, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
@kstolp Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 52600,
"author": "kstolp",
"headCommitOid": "4de56dd4646f2d78ed5f9d6c41c502e564148fa7",
"lastPushDate": "2021-01-30T17:27:03.000Z",
"lastActivityDate": "2021-05-10T23:36:38.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2021-05-10T22:10:37.000Z",
"mergeRequestDate": "2021-05-10T23:36:38.000Z",
"mergeRequestUser": "kstolp",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "koa-joi-router",
"kind": "edit",
"files": [
{
"path": "types/koa-joi-router/index.d.ts",
"kind": "definition"
}
],
"owners": [
"wingsbob",
"move-zig",
"hirochachacha",
"NotWoods",
"sourrust"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"ciResult": "pass"
} |
🔔 @wingsbob @move-zig @hirochachacha @NotWoods @sourrust — please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt. It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@kstolp Everything looks good here. Great job! I am ready to merge this PR (at 4de56dd) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@wingsbob, @move-zig, @hirochachacha, @NotWoods, @sourrust: you can do this too.) |
Ready to merge |
I just published |
Please fill in this template.
npm test <package to test>
.If changing an existing definition: