Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[koa-joi-router] Update maxBody type to match documentation and dependency type #52600

Merged
merged 1 commit into from May 10, 2021
Merged

Conversation

kstolp
Copy link
Contributor

@kstolp kstolp commented Apr 26, 2021

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/koajs/joi-router/blob/master/README.md>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot typescript-bot added Untested Change This PR does not touch tests Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 26, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 26, 2021

Hey @kstolp,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot added this to Needs Maintainer Action in New Pull Request Status Board Apr 26, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 26, 2021

@kstolp Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 52600,
  "author": "kstolp",
  "headCommitOid": "4de56dd4646f2d78ed5f9d6c41c502e564148fa7",
  "lastPushDate": "2021-01-30T17:27:03.000Z",
  "lastActivityDate": "2021-05-10T23:36:38.000Z",
  "maintainerBlessed": "Waiting for Author to Merge",
  "mergeOfferDate": "2021-05-10T22:10:37.000Z",
  "mergeRequestDate": "2021-05-10T23:36:38.000Z",
  "mergeRequestUser": "kstolp",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "koa-joi-router",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa-joi-router/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "wingsbob",
        "move-zig",
        "hirochachacha",
        "NotWoods",
        "sourrust"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @wingsbob @move-zig @hirochachacha @NotWoods @sourrust — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @kstolp.

(Ping @wingsbob, @move-zig, @hirochachacha, @NotWoods, @sourrust.)

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #52600 diff
Batch compilation
Memory usage (MiB) 90.2 89.4 -1.0%
Type count 16937 16937 0%
Assignability cache size 4722 4722 0%
Language service
Samples taken 297 297 0%
Identifiers in tests 297 297 0%
getCompletionsAtPosition
    Mean duration (ms) 386.6 459.7 +18.9%
    Mean CV 9.6% 8.8%
    Worst duration (ms) 485.0 565.8 +16.7%
    Worst identifier ctx koa
getQuickInfoAtPosition
    Mean duration (ms) 393.9 466.7 +18.5%
    Mean CV 10.3% 8.9%
    Worst duration (ms) 499.6 583.3 +16.8%
    Worst identifier ctx koa
System information
Node version v14.16.1 v14.16.1
CPU count 2 2
CPU speed 2.095 GHz 2.294 GHz
CPU model Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1113-azure 4.15.0-1113-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Apr 26, 2021
@elibarzilay elibarzilay moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board May 10, 2021
@typescript-bot typescript-bot added Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 10, 2021
@typescript-bot
Copy link
Contributor

@kstolp Everything looks good here. Great job! I am ready to merge this PR (at 4de56dd) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@wingsbob, @move-zig, @hirochachacha, @NotWoods, @sourrust: you can do this too.)

@kstolp
Copy link
Contributor Author

kstolp commented May 10, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 10, 2021
@typescript-bot typescript-bot merged commit 197e671 into DefinitelyTyped:master May 10, 2021
@typescript-bot
Copy link
Contributor

I just published @types/koa-joi-router@8.0.0 to npm.

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants