Fix mapbog-gl SymbolLayer style definition

[OttyLab]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <https://docs.mapbox.com/mapbox-gl-js/style-spec/layers/#layout-symbol-text-justify, https://docs.mapbox.com/mapbox-gl-js/style-spec/layers/#layout-symbol-icon-ignore-placement>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@OttyLab Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• mapbox-gl on npm, on unpkg
  • owner-approval: @dmytro-gokun

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52616,
  "author": "OttyLab",
  "headCommitOid": "5294b518a233c13c918f367de353768b56440af4",
  "lastPushDate": "2021-04-27T13:57:36.000Z",
  "lastActivityDate": "2021-05-05T14:45:28.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-05-05T13:10:32.000Z",
  "mergeRequestDate": "2021-05-05T14:45:28.000Z",
  "mergeRequestUser": "dmytro-gokun",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "mapbox-gl",
      "kind": "edit",
      "files": [
        {
          "path": "types/mapbox-gl/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mapbox-gl/mapbox-gl-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "dobrud",
        "patrickr",
        "macobo",
        "dmytro-gokun",
        "LiamAttClarke",
        "life777",
        "mklopets",
        "amxfonseca",
        "Nosfit"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "dmytro-gokun",
      "date": "2021-05-05T11:48:30.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @dobrud @PatrickR @macobo @dmytro-gokun @LiamAttClarke @life777 @mklopets @amxfonseca @Nosfit — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[OttyLab]

To reviewer

I have a question about how to do same update for old version v1.13.0. If I understand correctly, 1.13.0 is for Mapbox GL JS v1.13.x that is still available and the implementation is different from v2.x. The old version v1.13.0 has same style definition issue and I want to fix it.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#52616	diff
Batch compilation
Memory usage (MiB)	80.1	80.3	+0.3%
Type count	12722	12722	0%
Assignability cache size	4489	4489	0%
Language service
Samples taken	2575	2577	0%
Identifiers in tests	2575	2577	0%
getCompletionsAtPosition
Mean duration (ms)	340.7	329.0	-3.4%
Mean CV	10.0%	9.8%
Worst duration (ms)	484.1	459.5	-5.1%
Worst identifier	document	ev
getQuickInfoAtPosition
Mean duration (ms)	340.4	328.1	-3.6%
Mean CV	10.3%	10.2%
Worst duration (ms)	526.6	482.0	-8.5%
Worst identifier	querySelector	querySelector

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@OttyLab Everything looks good here. Great job! I am ready to merge this PR (at 5294b51) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dobrud, @PatrickR, @macobo, @dmytro-gokun, @LiamAttClarke, @life777, @mklopets, @amxfonseca, @Nosfit: you can do this too.)

[dmytro-gokun]

Ready to merge