Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3] Upgrade types to v6.5 #53092

Merged
merged 2 commits into from May 19, 2021
Merged

Conversation

Methuselah96
Copy link
Contributor

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/d3/d3/releases/tag/v6.5.0
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. labels May 19, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 19, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented May 19, 2021

@Methuselah96 Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53092,
  "author": "Methuselah96",
  "headCommitOid": "ea5834be4d645295eab6b3788b897031114a6b29",
  "lastPushDate": "2021-05-19T01:00:58.000Z",
  "lastActivityDate": "2021-05-19T01:01:35.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "d3-array",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3-array/d3-array-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/d3-array/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "gustavderdrache",
        "borisyankov",
        "tomwanzek",
        "denisname",
        "ledragon",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "d3",
      "kind": "edit",
      "files": [
        {
          "path": "types/d3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "tomwanzek",
        "gustavderdrache",
        "borisyankov",
        "denisname",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @gustavderdrache @borisyankov @tomwanzek @denisname @Ledragon — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 19, 2021
@weswigham weswigham merged commit 0318503 into DefinitelyTyped:master May 19, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 19, 2021
@typescript-bot
Copy link
Contributor

I just published @types/d3@6.5.0 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/d3-array@2.11.0 to npm.

@Methuselah96 Methuselah96 deleted the d3-6.5 branch May 19, 2021 03:26
@Methuselah96 Methuselah96 mentioned this pull request May 19, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants