New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[d3] Update types to v6.7 #53178
[d3] Update types to v6.7 #53178
Conversation
@Methuselah96 Thank you for submitting this PR! This is a live comment which I will keep updated. 3 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes in this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53178,
"author": "Methuselah96",
"headCommitOid": "1c7668d1f6f8a53330e2ba062ec948631f669364",
"lastPushDate": "2021-05-21T19:10:29.000Z",
"lastActivityDate": "2021-05-21T19:11:11.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "d3-scale",
"kind": "edit",
"files": [
{
"path": "types/d3-scale/index.d.ts",
"kind": "definition"
}
],
"owners": [
"tomwanzek",
"gustavderdrache",
"borisyankov",
"denisname",
"rulonder",
"Methuselah96"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "d3-time",
"kind": "edit",
"files": [
{
"path": "types/d3-time/d3-time-tests.ts",
"kind": "test"
},
{
"path": "types/d3-time/index.d.ts",
"kind": "definition"
}
],
"owners": [
"tomwanzek",
"gustavderdrache",
"borisyankov",
"denisname",
"Methuselah96"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "d3",
"kind": "edit",
"files": [
{
"path": "types/d3/index.d.ts",
"kind": "definition"
}
],
"owners": [
"tomwanzek",
"gustavderdrache",
"borisyankov",
"denisname",
"Methuselah96"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 846187498,
"ciResult": "pass"
} |
🔔 @tomwanzek @gustavderdrache @borisyankov @denisname @rulonder — please review this PR in the next few days. Be sure to explicitly select |
I just published |
I just published |
I just published |
Please fill in this template.
npm test <package to test>
.If changing an existing definition: