Added types for plotly.js-basic-dist

[DreierF]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

Links:

• https://www.npmjs.com/package/plotly.js-basic-dist
• https://github.com/plotly/plotly.js/blob/master/dist/README.md#plotlyjs-basic

[typescript-bot]

@DreierF Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• plotly.js-basic-dist (new!) — on npm, on unpkg
  • 1 added owner: ✎@DreierF

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes in this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 53783,
  "author": "DreierF",
  "headCommitOid": "0ae3f91756a80740b0e9f64de4c6d946aa51dc1f",
  "lastPushDate": "2021-06-13T03:39:13.000Z",
  "lastActivityDate": "2021-06-13T17:31:06.000Z",
  "mergeOfferDate": "2021-06-13T17:04:16.000Z",
  "mergeRequestDate": "2021-06-13T17:31:06.000Z",
  "mergeRequestUser": "DreierF",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "plotly.js-basic-dist",
      "kind": "add",
      "files": [
        {
          "path": "types/plotly.js-basic-dist/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/plotly.js-basic-dist/plotly.js-basic-dist-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/plotly.js-basic-dist/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/plotly.js-basic-dist/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "DreierF"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-06-13T17:03:41.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 860031907,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @DreierF — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

@DreierF The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[DreierF]

🔔 @DreierF — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@chrisgervang @martinduparc @frederikaalund @taoqf @Dadstart @szechyjs @soorajpudiyadath @jonfreedman @meganrm @milesjos @SkipperCool @mtadams007 @marnett-git @peterblazejewicz @brammitch @blizzardjessica @olegshilov @PabloGracia

As all of you contributed to the plotly.js package, could someone of you review this change?

[peterblazejewicz]

@DreierF does it mean only some types of traces should be re-exported from plotly.js? At the moment, IMO this package
is just a pass-through for all plotly.js definitions.

[typescript-bot]

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[DreierF]

Thanks for the review!
Yes, ideally only the relevant subset should be re-exported, but it would be an enormous effort to cherry-pick only the relevant types. WDYT?

I took inspiration of the jQuery slim package, which also just exposes a subset of jQuery in reality, but exports all the types.

[peterblazejewicz]

@DreierF agree, LGTM!
thx!

[DreierF]

Ready to merge

[typescript-bot]

I just published @types/plotly.js-basic-dist@1.54.0 to npm.