Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New @ckeditor/ckeditor5-real-time-collaboration v27.1 #53792

Conversation

fedemp
Copy link
Contributor

@fedemp fedemp commented Jun 12, 2021

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 12, 2021

@fedemp Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes in this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53792,
  "author": "fedemp",
  "headCommitOid": "8f7a4a1ff1089851b33dcc8faa2ff243ef757d49",
  "lastPushDate": "2021-06-12T20:06:16.000Z",
  "lastActivityDate": "2021-06-12T21:15:11.000Z",
  "mergeOfferDate": "2021-06-12T20:34:16.000Z",
  "mergeRequestDate": "2021-06-12T21:15:11.000Z",
  "mergeRequestUser": "fedemp",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "ckeditor__ckeditor5-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/ckeditor__ckeditor5-core/src/editor/editorconfig.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "fedemp",
        "denisname"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "ckeditor__ckeditor5-real-time-collaboration",
      "kind": "add",
      "files": [
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/ckeditor__ckeditor5-real-time-collaboration-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/src/presencelist.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborationclient.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativecomments.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativeediting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativeediting/sessions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativetrackchanges.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ckeditor__ckeditor5-real-time-collaboration/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "fedemp"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-06-12T20:33:43.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 860102680,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Edits multiple packages labels Jun 12, 2021
@typescript-bot
Copy link
Contributor

🔔 @denisname — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jun 12, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jun 12, 2021
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@fedemp thx!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 12, 2021
@typescript-bot
Copy link
Contributor

@fedemp Everything looks good here. Great job! I am ready to merge this PR (at 8f7a4a1) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Jun 12, 2021
@fedemp
Copy link
Contributor Author

fedemp commented Jun 12, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jun 12, 2021
@typescript-bot typescript-bot merged commit de68989 into DefinitelyTyped:master Jun 12, 2021
@typescript-bot
Copy link
Contributor

I just published @types/ckeditor__ckeditor5-core@27.0.18 to npm.

@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits multiple packages Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants