New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New @ckeditor/ckeditor5-real-time-collaboration v27.1 #53792
New @ckeditor/ckeditor5-real-time-collaboration v27.1 #53792
Conversation
@fedemp Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes in this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53792,
"author": "fedemp",
"headCommitOid": "8f7a4a1ff1089851b33dcc8faa2ff243ef757d49",
"lastPushDate": "2021-06-12T20:06:16.000Z",
"lastActivityDate": "2021-06-12T21:15:11.000Z",
"mergeOfferDate": "2021-06-12T20:34:16.000Z",
"mergeRequestDate": "2021-06-12T21:15:11.000Z",
"mergeRequestUser": "fedemp",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "ckeditor__ckeditor5-core",
"kind": "edit",
"files": [
{
"path": "types/ckeditor__ckeditor5-core/src/editor/editorconfig.d.ts",
"kind": "definition"
}
],
"owners": [
"fedemp",
"denisname"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "ckeditor__ckeditor5-real-time-collaboration",
"kind": "add",
"files": [
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/ckeditor__ckeditor5-real-time-collaboration-tests.ts",
"kind": "test"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/index.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/src/presencelist.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborationclient.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativecomments.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativeediting.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativeediting/sessions.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/src/realtimecollaborativetrackchanges.d.ts",
"kind": "definition"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/ckeditor__ckeditor5-real-time-collaboration/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"fedemp"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-06-12T20:33:43.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 860102680,
"ciResult": "pass"
} |
🔔 @denisname — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@fedemp thx!
Ready to merge |
I just published |
I just published |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.