Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maplibre-gl): typings are now included in maplibre-gl #54204

Merged
merged 1 commit into from Jul 9, 2021

Conversation

folke
Copy link
Contributor

@folke folke commented Jul 1, 2021

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 1, 2021

@folke Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54204,
  "author": "folke",
  "headCommitOid": "2a47ee51ccab1ee25032505c232844cbf5d7bc53",
  "lastPushDate": "2021-07-09T09:39:17.000Z",
  "lastActivityDate": "2021-07-09T16:13:43.000Z",
  "maintainerBlessed": "Waiting for Author to Merge",
  "mergeOfferDate": "2021-07-09T16:00:32.000Z",
  "mergeRequestDate": "2021-07-09T16:13:43.000Z",
  "mergeRequestUser": "folke",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "maplibre-gl",
      "kind": "delete",
      "files": [
        {
          "path": "types/maplibre-gl/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/maplibre-gl/maplibre-gl-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/maplibre-gl/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/maplibre-gl/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dobrud",
        "patrickr",
        "macobo",
        "dmytro-gokun",
        "LiamAttClarke",
        "life777",
        "mklopets",
        "amxfonseca",
        "folke"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 872149364,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @dobrud @PatrickR @macobo @dmytro-gokun @LiamAttClarke @life777 @mklopets @amxfonseca — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Needs Maintainer Action in New Pull Request Status Board Jul 1, 2021
@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jul 8, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in New Pull Request Status Board Jul 8, 2021
@typescript-bot
Copy link
Contributor

@folke Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jul 9, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jul 9, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jul 9, 2021
@elibarzilay elibarzilay moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Jul 9, 2021
@typescript-bot typescript-bot added the Self Merge This PR can now be self-merged by the PR author or an owner label Jul 9, 2021
@typescript-bot
Copy link
Contributor

@folke: Everything looks good here. I am ready to merge this PR (at 2a47ee5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@dobrud, @PatrickR, @macobo, @dmytro-gokun, @LiamAttClarke, @life777, @mklopets, @amxfonseca: you can do this too.)

@folke
Copy link
Contributor Author

folke commented Jul 9, 2021

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jul 9, 2021
@typescript-bot typescript-bot merged commit 78c9bd7 into DefinitelyTyped:master Jul 9, 2021
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants