New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(maplibre-gl): typings are now included in maplibre-gl #54204
fix(maplibre-gl): typings are now included in maplibre-gl #54204
Conversation
@folke Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 1 package in this PR (and infra files)Code ReviewsThis PR can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54204,
"author": "folke",
"headCommitOid": "2a47ee51ccab1ee25032505c232844cbf5d7bc53",
"lastPushDate": "2021-07-09T09:39:17.000Z",
"lastActivityDate": "2021-07-09T16:13:43.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2021-07-09T16:00:32.000Z",
"mergeRequestDate": "2021-07-09T16:13:43.000Z",
"mergeRequestUser": "folke",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "maplibre-gl",
"kind": "delete",
"files": [
{
"path": "types/maplibre-gl/index.d.ts",
"kind": "definition"
},
{
"path": "types/maplibre-gl/maplibre-gl-tests.ts",
"kind": "test"
},
{
"path": "types/maplibre-gl/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/maplibre-gl/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"dobrud",
"patrickr",
"macobo",
"dmytro-gokun",
"LiamAttClarke",
"life777",
"mklopets",
"amxfonseca",
"folke"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 872149364,
"ciResult": "pass"
} |
🔔 @dobrud @PatrickR @macobo @dmytro-gokun @LiamAttClarke @life777 @mklopets @amxfonseca — please review this PR in the next few days. Be sure to explicitly select |
@folke Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
@folke: Everything looks good here. I am ready to merge this PR (at 2a47ee5) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@dobrud, @PatrickR, @macobo, @dmytro-gokun, @LiamAttClarke, @life777, @mklopets, @amxfonseca: you can do this too.) |
Ready to merge |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
If removing a declaration:
notNeededPackages.json
.