-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Request to include rawBody property #56766
Conversation
The `rawBody` property is a property which the restify team intend to support: restify/node-restify#928 restify/plugins#6 Having it available in the typing enables access to this property.
@dzhang-ssense Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 56766,
"author": "dzhang-ssense",
"headCommitOid": "9fad6da8e9ab51248265b31a114c83a2c477e353",
"lastPushDate": "2021-10-25T19:16:32.000Z",
"lastActivityDate": "2021-11-05T16:55:48.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2021-11-02T20:25:18.000Z",
"mergeRequestDate": "2021-11-05T16:55:48.000Z",
"mergeRequestUser": "dzhang-ssense",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "restify",
"kind": "edit",
"files": [
{
"path": "types/restify/index.d.ts",
"kind": "definition"
}
],
"owners": [
"blittle",
"stevehipwell",
"leanazulyoro",
"mgebundy",
"alcmoraes",
"quinnlangille",
"GaikwadPratik"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "quinnlangille",
"date": "2021-10-27T01:15:53.000Z",
"isMaintainer": false
},
{
"type": "stale",
"reviewer": "phaubertinssense",
"date": "2021-10-25T19:01:53.000Z",
"abbrOid": "afb0d13"
}
],
"mainBotCommentID": 951216482,
"ciResult": "pass"
} |
🔔 @blittle @stevehipwell @leanazulyoro @mgebundy @alcmoraes @quinnlangille @GaikwadPratik — please review this PR in the next few days. Be sure to explicitly select |
@dzhang-ssense The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@phaubertinssense Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good too add a test in the restify-tests.ts
file, just asserting that rawBody
should be available
⏳ Hi @dzhang-ssense, It's been a few days since this PR was approved by quinnlangille and we're waiting for a DT maintainer to give a review. If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the |
For future reference, adding tests would have made this quicker. |
Ready to merge |
The
rawBody
property is a property which the restify team intend to support:restify/node-restify#928
restify/plugins#6
Having it available in the typing enables access to this property.
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should contain{ "extends": "dtslint/dt.json" }
, and no additional rules.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
If removing a declaration:
notNeededPackages.json
.