Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): fixed markdown for a link in the Italian documentation #57164

Merged
merged 1 commit into from Nov 15, 2021
Merged

fix(doc): fixed markdown for a link in the Italian documentation #57164

merged 1 commit into from Nov 15, 2021

Conversation

hpatoio
Copy link
Contributor

@hpatoio hpatoio commented Nov 15, 2021

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.

Select one of these and delete the others:

  • I've fixed a small issue in the markdown for the Italian documentation

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 15, 2021

@hpatoio Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect DT infrastructure (README.it.md)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57164,
  "author": "hpatoio",
  "headCommitOid": "2070d97433c2510dcff225cf8ed1405991f9d530",
  "lastPushDate": "2021-11-15T14:04:09.000Z",
  "lastActivityDate": "2021-11-15T14:29:07.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "README.it.md",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 968943749,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @hpatoio — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Nov 15, 2021
@hpatoio
Copy link
Contributor Author

hpatoio commented Nov 15, 2021

Following the advice by @typescript-bot I ping @euberdeveloper since he/she is the one who created the first version of the file

@euberdeveloper
Copy link
Contributor

Thanks

@weswigham weswigham merged commit a45bd30 into DefinitelyTyped:master Nov 15, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants