New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[indy-sdk] add some missing methods #57376
[indy-sdk] add some missing methods #57376
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57376,
"author": "TimoGlastra",
"headCommitOid": "1f39e122367556a0e49c3c868c1a6f52444356f1",
"lastPushDate": "2021-11-25T22:32:08.000Z",
"lastActivityDate": "2021-12-02T14:44:44.000Z",
"mergeOfferDate": "2021-12-02T14:44:20.000Z",
"mergeRequestDate": "2021-12-02T14:44:44.000Z",
"mergeRequestUser": "TimoGlastra",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "indy-sdk",
"kind": "edit",
"files": [
{
"path": "types/indy-sdk/index.d.ts",
"kind": "definition"
},
{
"path": "types/indy-sdk/indy-sdk-tests.ts",
"kind": "test"
}
],
"owners": [
"TimoGlastra",
"jakubkoci",
"karimStekelenburg"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakubkoci",
"date": "2021-12-02T14:43:42.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 979500331,
"ciResult": "pass"
} |
🔔 @jakubkoci @karimStekelenburg — please review this PR in the next few days. Be sure to explicitly select |
@TimoGlastra: Everything looks good here. I am ready to merge this PR (at 1f39e12) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@jakubkoci, @karimStekelenburg: you can do this too.) |
Ready to merge |
Add some missing methods currently using // @ts-ignore in AFJ
Signed-off-by: Timo Glastra timo@animo.id
Please fill in this template.
npm test <package to test>
.If changing an existing definition: