Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indy-sdk] add some missing methods #57376

Merged

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Nov 25, 2021

Add some missing methods currently using // @ts-ignore in AFJ

Signed-off-by: Timo Glastra timo@animo.id

Please fill in this template.

If changing an existing definition:

  • [ =x] Provide a URL to documentation or source code which provides context for the suggested changes: add missing methods
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

Signed-off-by: Timo Glastra <timo@animo.id>
@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 25, 2021

@TimoGlastra Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57376,
  "author": "TimoGlastra",
  "headCommitOid": "1f39e122367556a0e49c3c868c1a6f52444356f1",
  "lastPushDate": "2021-11-25T22:32:08.000Z",
  "lastActivityDate": "2021-12-02T14:44:44.000Z",
  "mergeOfferDate": "2021-12-02T14:44:20.000Z",
  "mergeRequestDate": "2021-12-02T14:44:44.000Z",
  "mergeRequestUser": "TimoGlastra",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "indy-sdk",
      "kind": "edit",
      "files": [
        {
          "path": "types/indy-sdk/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/indy-sdk/indy-sdk-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "TimoGlastra",
        "jakubkoci",
        "karimStekelenburg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakubkoci",
      "date": "2021-12-02T14:43:42.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 979500331,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Nov 25, 2021
@typescript-bot
Copy link
Contributor

🔔 @jakubkoci @karimStekelenburg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Nov 25, 2021
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 2, 2021
@typescript-bot
Copy link
Contributor

@TimoGlastra: Everything looks good here. I am ready to merge this PR (at 1f39e12) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jakubkoci, @karimStekelenburg: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Dec 2, 2021
@TimoGlastra
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Dec 2, 2021
@typescript-bot typescript-bot merged commit c674d80 into DefinitelyTyped:master Dec 2, 2021
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants