New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowExitOnIdle option to PoolConfig. #57501
Conversation
@educobuci Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57501,
"author": "educobuci",
"headCommitOid": "0555cfd53429a40418fcc155cd8c1c22be1878f9",
"lastPushDate": "2021-12-02T14:27:18.000Z",
"lastActivityDate": "2021-12-02T19:38:59.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "pg",
"kind": "edit",
"files": [
{
"path": "types/pg/index.d.ts",
"kind": "definition"
},
{
"path": "types/pg/pg-tests.ts",
"kind": "test"
}
],
"owners": [
"pspeter3",
"HoldYourWaffle"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 984685273,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0555cfd53429a40418fcc155cd8c1c22be1878f9/checks?check_suite_id=4533511855"
} |
🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select |
@educobuci The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
@sandersn The CI is still failing due to the update on @DefinitelyTyped |
Looks like the most recent CI run passed. @educobuci do you want to leave this closed? |
This changes update the PoolConfig options parameter to include the option
allowExitOnIdle
that was missing. The documentation for it is available herePlease fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: