Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowExitOnIdle option to PoolConfig. #57501

Closed
wants to merge 1 commit into from

Conversation

educobuci
Copy link
Contributor

@educobuci educobuci commented Dec 2, 2021

This changes update the PoolConfig options parameter to include the option allowExitOnIdle that was missing. The documentation for it is available here

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 2, 2021

@educobuci Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57501,
  "author": "educobuci",
  "headCommitOid": "0555cfd53429a40418fcc155cd8c1c22be1878f9",
  "lastPushDate": "2021-12-02T14:27:18.000Z",
  "lastActivityDate": "2021-12-02T19:38:59.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "pg",
      "kind": "edit",
      "files": [
        {
          "path": "types/pg/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/pg/pg-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "pspeter3",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 984685273,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/0555cfd53429a40418fcc155cd8c1c22be1878f9/checks?check_suite_id=4533511855"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Dec 2, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 2, 2021
@typescript-bot
Copy link
Contributor

🔔 @pspeter3 @HoldYourWaffle — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Dec 2, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Dec 2, 2021
@typescript-bot
Copy link
Contributor

@educobuci The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@educobuci
Copy link
Contributor Author

@sandersn The CI is still failing due to the update on @DefinitelyTyped
FatalError: Could not find config file at: /home/runner/work/DefinitelyTyped/DefinitelyTyped/node_modules/@definitelytyped/dtslint/bin/dtslint.json
This PR is updated with master. Do you know what the problem is?

@sandersn
Copy link
Contributor

sandersn commented Dec 2, 2021

Looks like the most recent CI run passed. @educobuci do you want to leave this closed?

@educobuci
Copy link
Contributor Author

@sandersn Yes. In my ignorance, I've closed this and opened another one to force the bot re-run and remove the failing status label. It is all sorted out now (I hope). I'm sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants