Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanReferencesAfterRun to 'mocha' #58203

Merged

Conversation

nicojs
Copy link
Contributor

@nicojs nicojs commented Jan 15, 2022

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://mochajs.org/api/mocha#cleanReferencesAfterRun
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 15, 2022

@nicojs Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

@nicojs: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58203,
  "author": "nicojs",
  "headCommitOid": "979f000bf5492af3a1d956d364b11538d9110bee",
  "mergeBaseOid": "e8760f8b6a72d8853c43474c785b6c4b5a2b0c9b",
  "lastPushDate": "2022-01-15T09:20:03.000Z",
  "lastActivityDate": "2022-01-15T12:21:16.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "mocha",
      "kind": "edit",
      "files": [
        {
          "path": "types/mocha/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mocha/mocha-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "kazimanzurrashid",
        "otiai10",
        "enlight",
        "cspotcode",
        "1999",
        "strangedev"
      ],
      "addedOwners": [
        "nicojs"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "strangedev",
      "date": "2022-01-15T12:19:11.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1013649815,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Critical package labels Jan 15, 2022
@typescript-bot
Copy link
Contributor

🔔 @kazimanzurrashid @otiai10 @enlight @cspotcode @1999 @strangedev — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jan 15, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

mocha (unpkg)

was missing the following properties:

  1. unloadFile
  2. xdescribe

Generated by 🚫 dangerJS against 979f000

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jan 15, 2022
@strangedev
Copy link
Contributor

Hey @nicojs 👋
Thanks for the PR! It looks good to me, but I'll have to double check later since I'm on mobile at the moment.

@nicojs
Copy link
Contributor Author

nicojs commented Jan 15, 2022

Sure. I'm a mocha maintainer, so maybe that helps as well 😘

Copy link
Contributor

@strangedev strangedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 15, 2022
@strangedev
Copy link
Contributor

Hey @nicojs 👋 Thank you again for the PR, awesome to have an owner for the types who is also a contributor to mocha 😄

@sandersn sandersn merged commit eda07a7 into DefinitelyTyped:master Jan 19, 2022
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jan 19, 2022
@nicojs nicojs deleted the mocha/clean-references-after-run branch January 21, 2022 13:42
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants