-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cleanReferencesAfterRun
to 'mocha'
#58203
Add cleanReferencesAfterRun
to 'mocha'
#58203
Conversation
@nicojs Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
@nicojs: I see that you have added yourself as an owner, are you sure you want to become an owner? Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58203,
"author": "nicojs",
"headCommitOid": "979f000bf5492af3a1d956d364b11538d9110bee",
"mergeBaseOid": "e8760f8b6a72d8853c43474c785b6c4b5a2b0c9b",
"lastPushDate": "2022-01-15T09:20:03.000Z",
"lastActivityDate": "2022-01-15T12:21:16.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "mocha",
"kind": "edit",
"files": [
{
"path": "types/mocha/index.d.ts",
"kind": "definition"
},
{
"path": "types/mocha/mocha-tests.ts",
"kind": "test"
}
],
"owners": [
"kazimanzurrashid",
"otiai10",
"enlight",
"cspotcode",
"1999",
"strangedev"
],
"addedOwners": [
"nicojs"
],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "strangedev",
"date": "2022-01-15T12:19:11.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1013649815,
"ciResult": "pass"
} |
🔔 @kazimanzurrashid @otiai10 @enlight @cspotcode @1999 @strangedev — please review this PR in the next few days. Be sure to explicitly select |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. mocha (unpkg)was missing the following properties:
|
Hey @nicojs 👋 |
Sure. I'm a mocha maintainer, so maybe that helps as well 😘 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nicojs 👋 Thank you again for the PR, awesome to have an owner for the types who is also a contributor to mocha 😄 |
* Add `cleanReferencesAfterRun` to 'mocha' See https://mochajs.org/api/mocha#cleanReferencesAfterRun * update header
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: