[p5] updated to latest (V1.4.0) #58331

Gaweph · 2022-01-20T13:31:31Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

If changing an existing definition:

If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

typescript-bot · 2022-01-20T13:32:12Z

@Gaweph Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

p5 — on npm, on unpkg
- owner-approval: @Zalastax
- 1 added owner: ✎@Gaweph
- Config files to check:
  - p5/tslint.json: not the expected form and not moving towards it (check: rules, cliOptions)

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect module config files

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 58331,
  "author": "Gaweph",
  "headCommitOid": "1c4852bae80e1878a5c53e5bab39d7aadb1c0277",
  "mergeBaseOid": "ba9c5ca17fd39d9e7e3ce89be9fafd6b1bc9e24f",
  "lastPushDate": "2022-01-20T16:21:42.000Z",
  "lastActivityDate": "2022-01-27T20:58:30.000Z",
  "mergeOfferDate": "2022-01-27T20:42:47.000Z",
  "mergeRequestDate": "2022-01-27T20:58:30.000Z",
  "mergeRequestUser": "Gaweph",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "p5",
      "kind": "edit",
      "files": [
        {
          "path": "types/p5/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/lib/addons/p5.sound.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/literals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/accessibility/describe.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/accessibility/outputs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/color/creating_reading.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/color/p5.Color.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/color/setting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/environment.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/p5.Element.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/p5.Graphics.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/p5.Renderer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/rendering.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/shape/2d_primitives.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/shape/attributes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/shape/curves.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/shape/vertex.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/structure.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/core/transform.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/data/local_storage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/data/p5.TypedDict.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/dom/dom.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/events/acceleration.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/events/keyboard.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/events/mouse.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/image/image.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/image/loading_displaying.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/image/p5.Image.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/image/pixels.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/io/files.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/io/p5.Table.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/math/calculation.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/math/noise.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/math/p5.Vector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/math/random.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/math/trigonometry.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/typography/attributes.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/typography/loading_displaying.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/typography/p5.Font.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/utilities/array_functions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/utilities/conversion.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/utilities/string_functions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/utilities/time_date.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/3d_primitives.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/interaction.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/light.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/loading.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/material.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/p5.Camera.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/p5.Geometry.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/p5.RendererGL.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/src/webgl/p5.Shader.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/p5/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/p5/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/p5/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it (check: `rules`, `cliOptions`)"
        }
      ],
      "owners": [
        "p5-types",
        "Zalastax",
        "rahulv4667"
      ],
      "addedOwners": [
        "gaweph"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-01-27T20:42:08.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Zalastax",
      "date": "2022-01-24T09:39:39.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1017508025,
  "ciResult": "pass"
}

typescript-bot · 2022-01-20T13:32:15Z

🔔 @p5-types @Zalastax @rahulv4667 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

typescript-bot · 2022-01-20T13:33:22Z

@Gaweph The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2022-01-20T13:37:51Z

@Gaweph The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

typescript-bot · 2022-01-20T13:49:43Z

@Gaweph The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Gaweph · 2022-01-20T16:08:52Z

Fixes the problem identified here (p5 typings out of date):
Gaweph/p5-typescript-starter#28

Zalastax

Looks good and uses the preferred tooling for updating p5.js types so that's great!

Gaweph · 2022-01-25T12:49:31Z

@typescript-bot is there anything more that needs to be done to get this PR approved?

Gaweph · 2022-01-27T09:31:52Z

Ready to merge

typescript-bot · 2022-01-27T09:32:27Z

🛂 Hi @Gaweph,

I can't accept a pull request until all of the checks in the "Status" section of this comment are green. I will let you know once that happens.

Thanks, and happy typing!

yama-yeah · 2022-01-27T17:36:08Z

Hello, @Gaweph
I have been asked by @Zalastax to leave a comment here.
#58165 (review)
I think We need to change the definition of p5.js to be able to handle 4x4 matrix.
It seems to me that the definition of applyMatrix is wrong.
The applyMatrix have to specify the arguments one by one.
If you can, could you please check my PR once?　#58165
I'm not used to speaking in English, so I apologize if there are any rude expressions.

gabritto · 2022-01-27T20:34:31Z

types/p5/tslint.json

        "unified-signatures": false
-    }
+    },
+    "cliOptions": {


Why are those changes needed?

typescript-bot · 2022-01-27T20:42:47Z

@Gaweph: Everything looks good here. I am ready to merge this PR (at 1c4852b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@p5-types, @Zalastax, @rahulv4667: you can do this too.)

Gaweph · 2022-01-27T20:58:30Z

Ready to merge

…Gaweph

…Gaweph * Updated to latest p5 version (1.4.0) * Removed unused file * Removed unwanted files * Updated to use @definitelytyped/dtslint/dt.json * Added users back in

Updated to latest p5 version (1.4.0)

a2203c8

typescript-bot added Edits Owners This PR adds or removes owners Check Config Changes a module config files Huge Change labels Jan 20, 2022

typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jan 20, 2022

typescript-bot added the The CI failed When GH Actions fails label Jan 20, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jan 20, 2022

Removed unused file

c55440b

typescript-bot removed the The CI failed When GH Actions fails label Jan 20, 2022

typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jan 20, 2022

typescript-bot added the The CI failed When GH Actions fails label Jan 20, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jan 20, 2022

Removed unwanted files

dcc748c

typescript-bot removed the The CI failed When GH Actions fails label Jan 20, 2022

typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jan 20, 2022

typescript-bot added the The CI failed When GH Actions fails label Jan 20, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jan 20, 2022

Updated to use @definitelytyped/dtslint/dt.json

43c8ebc

typescript-bot removed the The CI failed When GH Actions fails label Jan 20, 2022

typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jan 20, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jan 20, 2022

Gaweph changed the title ~~p5 updated to latest (V1.4.0)~~ [@types/p5] updated to latest (V1.4.0) Jan 20, 2022

Gaweph changed the title ~~[@types/p5] updated to latest (V1.4.0)~~ [p5] updated to latest (V1.4.0) Jan 20, 2022

Added users back in

1c4852b

typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jan 20, 2022

typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jan 20, 2022

Gaweph mentioned this pull request Jan 20, 2022

How to use sound Gaweph/p5-typescript-starter#28

Closed

Gaweph closed this Jan 24, 2022

typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jan 24, 2022

Gaweph reopened this Jan 24, 2022

typescript-bot added this to Needs Maintainer Review in New Pull Request Status Board Jan 24, 2022

Zalastax approved these changes Jan 24, 2022

View reviewed changes

typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 24, 2022

yama-yeah mentioned this pull request Jan 27, 2022

[p5] Added new definition for applyMatrix method to handle 4x4 matrices. #58165

Closed

17 tasks

gabritto approved these changes Jan 27, 2022

View reviewed changes

types/p5/tslint.json

"unified-signatures": false

}

},

"cliOptions": {

Copy link

Contributor

gabritto Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those changes needed?

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 27, 2022

typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Jan 27, 2022

typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jan 27, 2022

typescript-bot merged commit 77c60a2 into DefinitelyTyped:master Jan 27, 2022

typescript-bot removed this from Recently Merged in New Pull Request Status Board Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[p5] updated to latest (V1.4.0) #58331

[p5] updated to latest (V1.4.0) #58331

Gaweph commented Jan 20, 2022 •

edited

typescript-bot commented Jan 20, 2022 •

edited

typescript-bot commented Jan 20, 2022

typescript-bot commented Jan 20, 2022

typescript-bot commented Jan 20, 2022

typescript-bot commented Jan 20, 2022

Gaweph commented Jan 20, 2022 •

edited

Zalastax left a comment

Gaweph commented Jan 25, 2022

Gaweph commented Jan 27, 2022

typescript-bot commented Jan 27, 2022

yama-yeah commented Jan 27, 2022

gabritto Jan 27, 2022

typescript-bot commented Jan 27, 2022

Gaweph commented Jan 27, 2022

[p5] updated to latest (V1.4.0) #58331

[p5] updated to latest (V1.4.0) #58331

Conversation

Gaweph commented Jan 20, 2022 • edited

typescript-bot commented Jan 20, 2022 • edited

1 package in this PR

Code Reviews

Status

typescript-bot commented Jan 20, 2022

typescript-bot commented Jan 20, 2022

typescript-bot commented Jan 20, 2022

typescript-bot commented Jan 20, 2022

Gaweph commented Jan 20, 2022 • edited

Zalastax left a comment

Choose a reason for hiding this comment

Gaweph commented Jan 25, 2022

Gaweph commented Jan 27, 2022

typescript-bot commented Jan 27, 2022

yama-yeah commented Jan 27, 2022

gabritto Jan 27, 2022

Choose a reason for hiding this comment

typescript-bot commented Jan 27, 2022

Gaweph commented Jan 27, 2022

Gaweph commented Jan 20, 2022 •

edited

typescript-bot commented Jan 20, 2022 •

edited

Gaweph commented Jan 20, 2022 •

edited