Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-virtualized] Remove redundant props from List #58705

Merged
merged 1 commit into from Feb 18, 2022

Conversation

EvanHahn
Copy link
Contributor

#58648 updated Grid's prop types, but those didn't propagate to List because it duplicates them. This removes the duplicated props and just pulls them off of Grid.

This means the autocomplete documentation may refer to Grid instead of List in a few cases. Let me know if that's an issue and I can restore those.


If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 10, 2022

@EvanHahn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58705,
  "author": "EvanHahn",
  "headCommitOid": "a10a821243ccbd98a9f5151931594e59cde44c37",
  "mergeBaseOid": "ef2b15cd773c7a2544043c2dd93e544ad6906cc7",
  "lastPushDate": "2022-02-10T16:33:15.000Z",
  "lastActivityDate": "2022-02-18T20:42:58.000Z",
  "mergeOfferDate": "2022-02-18T18:25:46.000Z",
  "mergeRequestDate": "2022-02-18T20:42:58.000Z",
  "mergeRequestUser": "EvanHahn",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-virtualized",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-virtualized/dist/es/List.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "kaoDev",
        "guntherjh",
        "wasd171",
        "Stevearzh",
        "mgoszcz2",
        "brandonhall",
        "sbusch",
        "azmenak"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-02-18T18:25:08.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1035136877,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Feb 10, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Feb 10, 2022
@typescript-bot
Copy link
Contributor

Hey @EvanHahn,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @kaoDev @guntherjh @wasd171 @Stevearzh @mgoszcz2 @brandonhall @sbusch @azmenak — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Feb 10, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 18, 2022
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board Feb 18, 2022
@typescript-bot
Copy link
Contributor

@EvanHahn: Everything looks good here. I am ready to merge this PR (at a10a821) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@kaoDev, @guntherjh, @wasd171, @Stevearzh, @mgoszcz2, @brandonhall, @sbusch, @azmenak: you can do this too.)

@EvanHahn
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Feb 18, 2022
@typescript-bot typescript-bot merged commit 194f2db into DefinitelyTyped:master Feb 18, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 19, 2022
martin-badin pushed a commit to martin-badin/DefinitelyTyped that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants