[react] Remove bivariance hack for RefCallback to reject non-nullable instances in callbacks

[eps1lon]

Closes #58464

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  "React will call the ref callback with the DOM element when the component mounts, and call it with null when it unmounts"
• [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[ferdaber]

I agree with this change, though ref objects need to be bivariant, ref callbacks don't need to be and should reflect exactly how React calls it.

[eps1lon]

I agree with this change, though ref objects need to be bivariant, ref callbacks don't need to be and should reflect exactly how React calls it.

Alright, thanks.

Will split out the fixes into separate PRs since they should be landed regardless (in case we need to reintroduce the bivariance hack)

[rawatrupesh]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-grid-layout (unpkg)

was missing the following properties:

1. utils

Generated by 🚫 dangerJS against c056f08

This issue has been open for quite some time. I would appreciate a fix. #35370

[typescript-bot]

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

• react — on npm, on unpkg (author is owner)
• wordpress__block-editor — on npm, on unpkg
  • owner-approval: @dmsnell

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 58936,
  "author": "eps1lon",
  "headCommitOid": "74acb1a0a0a403255a021da3dd737af38a4aa1ab",
  "mergeBaseOid": "277df65eb7d3bad751f87fdc1dcfb9e7205bd46a",
  "lastPushDate": "2022-03-16T19:55:09.000Z",
  "lastActivityDate": "2022-03-19T07:08:07.000Z",
  "mergeOfferDate": "2022-03-18T19:50:25.000Z",
  "mergeRequestDate": "2022-03-19T07:08:07.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/tsx.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "wordpress__block-editor",
      "kind": "edit",
      "files": [
        {
          "path": "types/wordpress__block-editor/wordpress__block-editor-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "dsifford",
        "sirreal",
        "dmsnell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-03-18T19:49:46.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "dmsnell",
      "date": "2022-03-16T21:01:56.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1069612969,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav @dsifford @sirreal @dmsnell — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[dmsnell]

Looks great, thanks!

[typescript-bot]

@eps1lon: Everything looks good here. I am ready to merge this PR (at 74acb1a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

[eps1lon]

Let's see how this goes

[eps1lon]

Ready to merge