[convict] Rename InternalSchema "properties" to "_cvtProperties" (missing 6.0.0 change)

[merlindru]

mozilla/node-convict#318
mozilla/node-convict#353

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.) It's a single property rename!
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: Preparing convict 6 mozilla/node-convict#353
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@merlindru Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• convict — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 26 days — it is considered nearly abandoned!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 59622,
  "author": "merlindru",
  "headCommitOid": "10de62879d26fc461a30ef008491f681264b8837",
  "mergeBaseOid": "d6b527de9f5bf07aa905597563ec1dc995f84ac1",
  "lastPushDate": "2022-03-31T15:22:40.000Z",
  "lastActivityDate": "2022-03-31T15:27:12.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "convict",
      "kind": "edit",
      "files": [
        {
          "path": "types/convict/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Nemo157",
        "vesse",
        "elyscape",
        "msuntharesan",
        "xamgore",
        "petermetz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1084747590,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/10de62879d26fc461a30ef008491f681264b8837/checks?check_suite_id=5880425110"
}

[typescript-bot]

Hey @merlindru,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @Nemo157 @vesse @elyscape @msuntharesan @xamgore @petermetz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@merlindru The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@merlindru I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Apr 30th (in a week) if the issues aren't addressed.