-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update encoding-japanese for v2 #59656
Conversation
@p-chan Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59656,
"author": "p-chan",
"headCommitOid": "9986268aa2a92439893d055aeef55a04cdb79473",
"mergeBaseOid": "e93b92c2925cca9e52ff59a0705da57ff37c9bbb",
"lastPushDate": "2022-04-02T05:13:44.000Z",
"lastActivityDate": "2022-04-02T07:51:26.000Z",
"mergeOfferDate": "2022-04-02T07:51:04.000Z",
"mergeRequestDate": "2022-04-02T07:51:26.000Z",
"mergeRequestUser": "rhysd",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "encoding-japanese",
"kind": "edit",
"files": [
{
"path": "types/encoding-japanese/index.d.ts",
"kind": "definition"
},
{
"path": "types/encoding-japanese/test/encoding-japanese-tests.cjs.ts",
"kind": "test"
}
],
"owners": [
"rhysd",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rhysd",
"date": "2022-04-02T07:50:23.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1086536776,
"ciResult": "pass"
} |
🔔 @rhysd @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also add Encoding.version
? It was also added at 2.0.0 polygonplanet/encoding.js@bd3d6ef
@p-chan One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
@rhysd Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
@rhysd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the update.
@p-chan: Everything looks good here. I am ready to merge this PR (at 9986268) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@rhysd, @peterblazejewicz: you can do this too.) |
Ready to merge |
Please fill in this template.
npm test <package to test>
.If changing an existing definition: