Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @terraformer/wkt types #59985

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Add @terraformer/wkt types #59985

merged 1 commit into from
Apr 21, 2022

Conversation

fwang49asu
Copy link
Contributor

@fwang49asu fwang49asu commented Apr 21, 2022

Please fill in this template.

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

For the reference, similar PRs to add types for terraformer packages:
@terraformer/spatial
@terraformer/arcgis

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Apr 21, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

terraformer__wkt (unpkg)

was missing the following properties:

  1. Parser
  2. parser

Generated by 🚫 dangerJS against 54f041b

@fwang49asu fwang49asu marked this pull request as ready for review April 21, 2022 01:02
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 21, 2022

@fwang49asu Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59985,
  "author": "fwang49asu",
  "headCommitOid": "54f041b63174a205b1a6727b05d237a60445e6b4",
  "mergeBaseOid": "d9f6a812cc128c4b7be6a777aa1bc96473c86008",
  "lastPushDate": "2022-04-21T00:44:58.000Z",
  "lastActivityDate": "2022-04-21T03:13:17.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "terraformer__wkt",
      "kind": "add",
      "files": [
        {
          "path": "types/terraformer__wkt/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/terraformer__wkt/terraformer__wkt-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/terraformer__wkt/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/terraformer__wkt/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "fwang49asu"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jgravois",
      "date": "2022-04-21T03:13:17.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1104604738,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Apr 21, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in New Pull Request Status Board Apr 21, 2022
@typescript-bot
Copy link
Contributor

🔔 @fwang49asu — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@fwang49asu
Copy link
Contributor Author

fwang49asu commented Apr 21, 2022

@jgravois would you like to take a look? Thanks!

Copy link

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable enough to me. thanks for contributing these typings!

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 21, 2022
@sandersn sandersn merged commit f10a843 into DefinitelyTyped:master Apr 21, 2022
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package. Other Approved This PR was reviewed and signed-off by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants