Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle a workaround big.js ESM import #60496

Closed
wants to merge 4 commits into from
Closed

Handle a workaround big.js ESM import #60496

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ac5b5f
Handle a workaround big.js ESM import
jstasiak May 24, 2022
cd9c5c9
Actually use the new file
jstasiak May 24, 2022
0f9329b
Merge remote-tracking branch 'origin/master' into big.js-esm
jstasiak May 25, 2022
46e0e95
Fix a typo
jstasiak May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/big.js/OTHER_FILES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
big.mjs.d.ts
3 changes: 3 additions & 0 deletions types/big.js/big.mjs.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './';
import Big from '/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? It's unusual to import from an absolute path.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, fixed

export default Big;