Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(w3c-generic-sensor): added type for AmbientLightSensor #61541

Merged

Conversation

mandarini
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 2, 2022

@mandarini Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 44 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61541,
  "author": "mandarini",
  "headCommitOid": "d13dbb7ce43a04624a62a5c81872f44d353c251c",
  "mergeBaseOid": "28c69816b28fa2499b950ebf74d84e2fe5cc98d8",
  "lastPushDate": "2022-08-02T07:36:32.000Z",
  "lastActivityDate": "2022-08-02T13:10:34.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "w3c-generic-sensor",
      "kind": "edit",
      "files": [
        {
          "path": "types/w3c-generic-sensor/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/w3c-generic-sensor/w3c-generic-sensor-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "kenchris"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1202521505,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Aug 2, 2022
@typescript-bot
Copy link
Contributor

🔔 @kenchris — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Aug 13, 2022
@typescript-bot
Copy link
Contributor

Re-ping @kenchris:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @mandarini.

(Ping @kenchris.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Sep 11, 2022
@sandersn sandersn merged commit fa8db20 into DefinitelyTyped:master Sep 15, 2022
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants