Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEED HELP] Add generic type vaiant to Superagent's Request#send() #61593

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DevDengChao
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:


I got these when running npm test superagent:

=============
Error: D:/workspace/open-source/nodejs/DefinitelyTyped/types/superagent/index.d.ts:22:28
ERROR: 22:28   expect                   TypeScript@4.8 compile error:
Cannot find module 'cookiejar' or its corresponding type declarations.
ERROR: 233:24  no-unnecessary-generics  Type parameter T is used only once. See: https://github.com/microsoft/DefinitelyTyped-tools/blob/master/packages/dtslint/docs/no-unnecessary-generics.md

    at testTypesVersion (D:\workspace\open-source\nodejs\DefinitelyTyped\node_modules\@definitelytyped\dtslint\src\index.ts:235:11)
    at runTests (D:\workspace\open-source\nodejs\DefinitelyTyped\node_modules\@definitelytyped\dtslint\src\index.ts:197:7)
    at main (D:\workspace\open-source\nodejs\DefinitelyTyped\node_modules\@definitelytyped\dtslint\src\index.ts:83:5)

Is there anyone could help how to solve these error ?

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant